Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xdg-shell: Continue transform of popup until size fits #6521

Merged
merged 4 commits into from
Jun 16, 2024

Conversation

DashieTM
Copy link
Contributor

@DashieTM DashieTM commented Jun 15, 2024

Describe your PR, what does it fix/add?

  • applies all 3 steps of the protocol until it fits or doesn't find a suitable position
    This is before this change:
nautilus.mp4

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

There is an issue with opening the popup at the exact point where it should flip upwards -> it pops up, and then flips (this also exists in main)

Is it ready for merging, or does it need work?

Should be ready other than what's above

@vaxerski
Copy link
Member

image
excuse me?

@DashieTM
Copy link
Contributor Author

But why would they put slide as 1 and 2... ffs
aight, I'm gonna find a way to make the current order work and change the title and commit after.

@DashieTM DashieTM changed the title xdg_shell: Invert order of flip and slide xdg-shell: Continue transform of popup until size fits Jun 15, 2024
@DashieTM
Copy link
Contributor Author

There we go, proper order. It just didn't apply the flip because it tested if the flip change by itself would fix the position. Hence it continued and eventually failed to position the popup.

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gangsta, thanks

@vaxerski vaxerski merged commit 738530e into hyprwm:main Jun 16, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants