option to fix mouse breaking vrr #6483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaxerski
reviewed
Jun 13, 2024
|
can you clang-format? |
Yes. But I don't really like the result. Looks less readable to me. |
|
thats just how we roll, tests will fail without clang-format :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Added an option
cursor:no_break_fs_vrrwhich allows skippingscheduleFrameForMonitortriggered by mouse events for fullscreen apps with VRR enabled. It fixes #6222, #5918Added option
cursor:min_refresh_rateto keep minimum refresh rate for cursor movement. Should be set to at least the minimum vrr supported by monitor since there is no point in keeping it lower. The default is 24.Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
This option fixes VRR in games and other apps with high enough fps but causes mouse cursor freeze or stutter for others (e.g. fullscreen terminal or browser).
cursor:min_refresh_rateshould help with this issue.Is it ready for merging, or does it need work?
Ready for merging.