Fix layershell keyboard focus grabs (#4968) #6394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaxerski
reviewed
Jun 10, 2024
|
Will deal with that tomorrow. Also noticing that, unlike in a nested session, in a root session any mouse presses will result in a press->release if the surface has keyboard interactivity. Don't think this one is my bug due to basically just copying what you did but I'll also take a look tomorrow. |
outfoxxed
commented
Jun 10, 2024
|
Debugged the weird press-release thing mentioned above #6409 |
vaxerski
reviewed
Jun 10, 2024
outfoxxed
force-pushed
the
fix-layershell
branch
from
c353f2e
to
26a6456
Compare
vaxerski
reviewed
Jun 10, 2024
|
generally code is ok |
|
ran clang format, thats just unrelated junk from it |
outfoxxed
force-pushed
the
fix-layershell
branch
from
26a6456
to
cd1007c
Compare
|
undid unrelated c-f stuff |
Also focus the last instead of the first.
outfoxxed
force-pushed
the
fix-layershell
branch
from
cd1007c
to
ef34ac1
Compare
vaxerski
reviewed
Jun 10, 2024
outfoxxed
force-pushed
the
fix-layershell
branch
from
217f1e4
to
bcee3a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Is it ready for merging, or does it need work?
Ready to merge.