Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-order operations around index.yaml #19

Closed
wants to merge 2 commits into from
Closed

re-order operations around index.yaml #19

wants to merge 2 commits into from

Conversation

markhu
Copy link

@markhu markhu commented Dec 14, 2017

Moved the index.yaml retrieval after updating the chart.tgz to reduce the window for race conditions. #18

@markhu
re-order operations around index.yaml
2f12b02 
Moved the `index.yaml` retrieval _after_ updating the chart.tgz to reduce the window for race conditions.
@markhu markhu mentioned this pull request Dec 14, 2017
Open
@hypnoglow
Copy link
Owner

@markhu
I accept the idea of narrowing down the window of opportunity for race conditions.

But you broke the code (and introduced many unnecessary else conditions). Would you like to fix it under my review, or you just want a result, so I could take your idea and provide a correct code?

@markhu
Copy link
Author

markhu commented Dec 16, 2017 •
edited
Loading

Sorry about that. I don't know goLang, and foolishly winged it. Can you take over? Thanks!

@markhu markhu closed this Dec 16, 2017
hypnoglow added a commit that referenced this pull request Dec 19, 2017
@hypnoglow
Reorder push command operations
737a82c 
Narrow down the window of opportunity for race conditions

Reference issue: #18
The idea was presented in this PR: #19
@hypnoglow hypnoglow mentioned this pull request Dec 19, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markhu @hypnoglow