Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(test-tooling): fix WS identity server port publish configuration #3416

Conversation

petermetz
Copy link
Member

  1. The hostconfig portion of the container start configuration was not
    being set up correctly which made it so that the exposed ports were not
    published on randomized ports like they were supposed to.
  2. This caused the fabric-v2-2-x/run-transaction-with-ws-ids.test.ts
    test to fail because it couldn't map the container port to a host machine
    port.
  3. Setting up the ws-test-server.ts class so that it does map the ports
    to the host machine solved the issue.

Signed-off-by: Peter Somogyvari [email protected]

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@petermetz petermetz force-pushed the test-tooling-fix-ws-identity-server-port-cfg branch from 8b268bc to 6985243 Compare July 17, 2024 18:23
@petermetz petermetz disabled auto-merge July 17, 2024 18:32
1. The hostconfig portion of the container start configuration was not
being set up correctly which made it so that the exposed ports were not
published on randomized ports like they were supposed to.
2. This caused  the `fabric-v2-2-x/run-transaction-with-ws-ids.test.ts`
test to fail because it couldn't map the container port to a host machine
port.
3. Setting up the ws-test-server.ts class so that it does map the ports
to the host machine solved the issue.

Signed-off-by: Peter Somogyvari <[email protected]>
@petermetz petermetz force-pushed the test-tooling-fix-ws-identity-server-port-cfg branch from 6985243 to 16fd345 Compare July 17, 2024 20:06
@petermetz petermetz enabled auto-merge (rebase) July 17, 2024 20:08
@petermetz petermetz merged commit 87f5f60 into hyperledger:main Jul 17, 2024
140 of 143 checks passed
@petermetz petermetz deleted the test-tooling-fix-ws-identity-server-port-cfg branch July 17, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants