Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(connector-fabric): fix rename type to responseType getBlockV1() #3415

Conversation

petermetz
Copy link
Member

The system chaincode query method's returns were not decoded correctly
because the test request assembling code was not updated to call the
responseType as such (old name was type)

Signed-off-by: Peter Somogyvari [email protected]

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

The system chaincode query method's returns were not decoded correctly
because the test request assembling code was not updated to call the
responseType as such (old name was type)

Signed-off-by: Peter Somogyvari <[email protected]>
@petermetz petermetz merged commit 5660c4e into hyperledger:main Jul 17, 2024
143 checks passed
@petermetz petermetz deleted the test-connector-fabric-fix-query-system-chain-methods-test-response-type branch July 21, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants