feat(shared): Simplifying storage class creation with helm module #2351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sailajakommineni
requested review from
sownak,
suvajit-sarkar,
jagpreetsinghsasan,
arsulegai,
weihong-ou and
adityajoshi12
as code owners
sailajakommineni
force-pushed
the
develop
branch
2 times, most recently
from
695f5f1
to
fc657ef
Compare
sownak
requested changes
Aug 25, 2023
platforms/shared/configuration/roles/create/shared_helm_component/templates/storage_class.j2
Outdated
Show resolved
Hide resolved
platforms/shared/configuration/roles/delete/k8s_resources/tasks/main.yaml
Outdated
Show resolved
Hide resolved
platforms/shared/configuration/roles/setup/storageclass/tasks/main.yaml
Outdated
Show resolved
Hide resolved
platforms/shared/configuration/roles/setup/storageclass/tasks/main.yaml
Outdated
Show resolved
Hide resolved
platforms/shared/configuration/roles/setup/storageclass/tasks/main.yaml
Outdated
Show resolved
Hide resolved
sailajakommineni
force-pushed
the
develop
branch
4 times, most recently
from
a4204e2
to
a7b2e24
Compare
platforms/shared/configuration/roles/create/shared_helm_component/vars/main.yaml
Outdated
Show resolved
Hide resolved
sailajakommineni
force-pushed
the
develop
branch
from
a34abde
to
f1c44c4
Compare
sownak
reviewed
Aug 31, 2023
platforms/shared/configuration/roles/setup/vault_kubernetes/templates/cordaos-policy.tpl
Outdated
Show resolved
Hide resolved
… moved to shared folder This pull request addresses to refactor the current implementation of creating helm releases using GitOps to a more flexible approach by leveraging the ansible helm module and moving the creation of storage class roles to a share folder. The six platforms that have been modified to make them compatible with the shared "storage_class" charts and roles are: • Hyperledger-Besu • Hyperledger-Fabric • R3-corda • R3-corda-Ent • Quorum • Hyperledger- Indy Changes Made: Instead of using gitOps to create helm release, used helm module from ansible by creating jinja(j2) template. Moved the creation of storage class roles to a shared folder to use them across all the platforms. Fixes: hyperledger#2306 Signed-off-by: sailajakommineni <[email protected]>
sailajakommineni
force-pushed
the
develop
branch
from
b568ffa
to
97c6f26
Compare
sownak
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses to refactor the current implementation of creating helm releases using GitOps to a more flexible approach by leveraging the ansible helm module and moving the creation of storage class roles to a share folder.
The six platforms that have been modified to make them compatible with the shared "storage class" charts and roles are:
• Hyperledger-Besu
• Hyperledger-Fabric
• R3-corda
• R3-corda-Ent
• Quorum
• Hyperledger- Indy
Changes Made:
Instead of using gitOps to create helm release, used helm module from ansible by creating jinja(j2) template. Moved the creation of storage class roles to a shared folder to use them across all the platforms.
Fixes: #2306