Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default value for min peers before starting sync from 5 to 1 #7640

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

macfarla
Copy link
Contributor

PR description

Change default value for minimum number of peers required before starting sync (only used by non-PoS networks) from 5 to 1.

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Signed-off-by: Sally MacFarlane <[email protected]>
@matthew1001
Copy link
Contributor

I think I'm in favour of this change. The enterprise-profile.toml already sets sync-min-peers to 1 so it makes sense to just change the default.

Copy link
Contributor

@matthew1001 matthew1001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fab-10
Copy link
Contributor

fab-10 commented Sep 19, 2024

since it could make sense for private networks, for public ones that could increase the risk of syncing to the wrong fork, so could be possible to condition this on the basis if the network is public or private? probably looking at the presence or not of a custom genesis file?

@fab-10 fab-10 added the doc-change-required Indicates an issue or PR that requires doc to be updated label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-change-required Indicates an issue or PR that requires doc to be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants