Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle hadolint check failure with proper risk assessment #7637

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

pullurib
Copy link
Contributor

@pullurib pullurib commented Sep 18, 2024

PR description

Suppressing/Ignoring hadolint warning about the last USER in Dockerfile being the root user - with reasoning that the root user has very specific job to do and then besu runs as besu user .

Follow up to #7575

Fixed Issue(s)

Follow up fix to #4292

@fab-10 fab-10 enabled auto-merge (squash) September 18, 2024 17:30
@fab-10 fab-10 merged commit 96e9873 into hyperledger:main Sep 18, 2024
41 checks passed
@fab-10
Copy link
Contributor

fab-10 commented Sep 18, 2024

Still something not working https://github.com/hyperledger/besu/actions/runs/10927512262/job/30333865457 seems related to testDocker task

@pullurib
Copy link
Contributor Author

Looking into it, that gradle task runs fine locally on my Mac

@fab-10
Copy link
Contributor

fab-10 commented Sep 20, 2024

Running it on Linux we get this report

<testcase name="File /var/lib/besu owner" time="0.000">
<system-err>File: /var/lib/besu: owner: Expected &#34;root&#34; to equal &#34;besu&#34;</system-err>
<failure>File: /var/lib/besu: owner: Expected &#34;root&#34; to equal &#34;besu&#34;</failure>
</testcase>

the expected user does not match

@fab-10
Copy link
Contributor

fab-10 commented Sep 20, 2024

Fix for the CI issue #7655

@pullurib
Copy link
Contributor Author

@fab-10 Thanks for taking care of it. I wasn't able to repro with act runs and was planning on uploading the reports to see what was failing. This is a better approach to wait for besu that waiting a few seconds .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants