Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHANGELOG] upcoming breaking change for k8s nat #7534

Merged
merged 4 commits into from
Sep 16, 2024

Conversation

macfarla
Copy link
Contributor

PR description

Fixed Issue(s)

refs #7533

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Signed-off-by: Sally MacFarlane <[email protected]>
@macfarla macfarla changed the title upcoming breaking change for k8s nat [CHANGELOG] upcoming breaking change for k8s nat Aug 29, 2024
@macfarla
Copy link
Contributor Author

added check in BesuCommand to log a warning if this is used.

➜  b2 git:(k8s-nat-rm) ✗ besu --nat-method=KUBERNETES --Xnat-kube-service-name=asdf
2024-09-16 12:53:07.876+10:00 | main | INFO  | Besu | Starting Besu
2024-09-16 12:53:08.214+10:00 | main | WARN  | Besu | Kubernetes NAT method is deprecated. Please use Docker or UPNP
2024-09-16 12:53:08.215+10:00 | main | WARN  | Besu | `--Xnat-kube-service-name` and Kubernetes NAT method are deprecated. Please use Docker or UPNP

@macfarla macfarla merged commit 89dfa95 into hyperledger:main Sep 16, 2024
41 checks passed
@macfarla macfarla deleted the k8s-nat-rm branch September 16, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants