Removed unused code and suppressed warnings/errors #1262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alberto Leon <[email protected]>
Signed-off-by: Alberto Leon <[email protected]>
|
Nice! thanks. as we've discussed on discord, usually deadcode should be investigated, however since this is "legacy" code to be deleted in the future, this is fine |
gmulhearn
approved these changes
Jul 9, 2024
lukewli-anonyome
pushed a commit
to lukewli-anonyome/aries-vcx
that referenced
this pull request
Jul 25, 2024
* removed unused code and suppressed warnings/erros Signed-off-by: Alberto Leon <[email protected]> * fixed formatting Signed-off-by: Alberto Leon <[email protected]> --------- Signed-off-by: Alberto Leon <[email protected]> Signed-off-by: lli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#[allow(dead_code)].TryGetIndextrait code since its not being used.