Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

signer / crypto abstractions #39

Merged
merged 9 commits into from
Jun 25, 2024
Merged

signer / crypto abstractions #39

merged 9 commits into from
Jun 25, 2024

Conversation

vitiko
Copy link
Contributor

@vitiko vitiko commented Jun 24, 2024

No description provided.

@vitiko vitiko requested a review from a team as a code owner June 24, 2024 11:23
@SiriusPluge
crypto/signer
ab348f2 
Signed-off-by: Viktor Nosov <[email protected]>
@coveralls
Copy link

coveralls commented Jun 24, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9644469113

Details

  • 68 of 80 (85.0%) changed or added relevant lines in 3 files are covered.
  • 10 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.09%) to 57.157%
Changes Missing Coverage Covered Lines Changed/Added Lines %
extensions/envelope/signer.go 32 34 94.12%
extensions/envelope/middleware.go 18 21 85.71%
extensions/envelope/crypto.go 18 25 72.0%
Files with Coverage Reduction New Missed Lines %
extensions/token/balance_utxo.go 10 69.61%
Totals Coverage Status
Change from base Build 7459099486: -0.09%
Covered Lines: 3993
Relevant Lines: 6986
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 24, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9644502241

Details

  • 68 of 80 (85.0%) changed or added relevant lines in 3 files are covered.
  • 33 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 57.143%
Changes Missing Coverage Covered Lines Changed/Added Lines %
extensions/envelope/signer.go 32 34 94.12%
extensions/envelope/middleware.go 18 21 85.71%
extensions/envelope/crypto.go 18 25 72.0%
Files with Coverage Reduction New Missed Lines %
extensions/token/balance_utxo.go 10 69.61%
testing/mockstub.go 23 51.13%
Totals Coverage Status
Change from base Build 7459099486: -0.1%
Covered Lines: 3992
Relevant Lines: 6986
💛 - Coveralls

crypto/signer
99d9004 
Signed-off-by: Viktor Nosov <[email protected]>
@coveralls
Copy link

coveralls commented Jun 24, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9648195765

Details

  • 68 of 80 (85.0%) changed or added relevant lines in 3 files are covered.
  • 33 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 57.143%
Changes Missing Coverage Covered Lines Changed/Added Lines %
extensions/envelope/signer.go 32 34 94.12%
extensions/envelope/middleware.go 18 21 85.71%
extensions/envelope/crypto.go 18 25 72.0%
Files with Coverage Reduction New Missed Lines %
extensions/token/balance_utxo.go 10 69.61%
testing/mockstub.go 23 51.13%
Totals Coverage Status
Change from base Build 7459099486: -0.1%
Covered Lines: 3992
Relevant Lines: 6986
💛 - Coveralls

crypto/signer
3779ebf 
Signed-off-by: Viktor Nosov <[email protected]>
@coveralls
Copy link

coveralls commented Jun 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9659630862

Details

  • 71 of 80 (88.75%) changed or added relevant lines in 3 files are covered.
  • 33 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.07%) to 57.18%
Changes Missing Coverage Covered Lines Changed/Added Lines %
extensions/envelope/signer.go 32 34 94.12%
extensions/envelope/middleware.go 18 21 85.71%
extensions/envelope/crypto.go 21 25 84.0%
Files with Coverage Reduction New Missed Lines %
extensions/token/balance_utxo.go 10 69.61%
testing/mockstub.go 23 51.13%
Totals Coverage Status
Change from base Build 7459099486: -0.07%
Covered Lines: 3994
Relevant Lines: 6985
💛 - Coveralls

crypto/signer
75e61ef 
Signed-off-by: Viktor Nosov <[email protected]>
@coveralls
Copy link

coveralls commented Jun 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9659819960

Details

  • 73 of 82 (89.02%) changed or added relevant lines in 3 files are covered.
  • 23 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 57.349%
Changes Missing Coverage Covered Lines Changed/Added Lines %
extensions/envelope/signer.go 32 34 94.12%
extensions/envelope/middleware.go 18 21 85.71%
extensions/envelope/crypto.go 23 27 85.19%
Files with Coverage Reduction New Missed Lines %
testing/mockstub.go 23 51.13%
Totals Coverage Status
Change from base Build 7459099486: 0.1%
Covered Lines: 4007
Relevant Lines: 6987
💛 - Coveralls

crypto/signer
d2d65f3 
Signed-off-by: Viktor Nosov <[email protected]>
@coveralls
Copy link

coveralls commented Jun 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9660295537

Details

  • 73 of 85 (85.88%) changed or added relevant lines in 3 files are covered.
  • 33 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.08%) to 57.167%
Changes Missing Coverage Covered Lines Changed/Added Lines %
extensions/envelope/middleware.go 18 21 85.71%
extensions/envelope/crypto.go 23 27 85.19%
extensions/envelope/signer.go 32 37 86.49%
Files with Coverage Reduction New Missed Lines %
extensions/token/balance_utxo.go 10 69.61%
testing/mockstub.go 23 51.13%
Totals Coverage Status
Change from base Build 7459099486: -0.08%
Covered Lines: 3996
Relevant Lines: 6990
💛 - Coveralls

crypto/signer
73d2c92 
Signed-off-by: Viktor Nosov <[email protected]>
@coveralls
Copy link

coveralls commented Jun 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9661551078

Details

  • 76 of 88 (86.36%) changed or added relevant lines in 3 files are covered.
  • 33 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.06%) to 57.186%
Changes Missing Coverage Covered Lines Changed/Added Lines %
extensions/envelope/middleware.go 18 21 85.71%
extensions/envelope/crypto.go 23 27 85.19%
extensions/envelope/signer.go 35 40 87.5%
Files with Coverage Reduction New Missed Lines %
extensions/token/balance_utxo.go 10 69.61%
testing/mockstub.go 23 51.13%
Totals Coverage Status
Change from base Build 7459099486: -0.06%
Covered Lines: 3999
Relevant Lines: 6993
💛 - Coveralls

crypto/signer
8cb2d28 
Signed-off-by: Viktor Nosov <[email protected]>
@coveralls
Copy link

coveralls commented Jun 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9662664540

Details

  • 73 of 82 (89.02%) changed or added relevant lines in 3 files are covered.
  • 33 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.05%) to 57.192%
Changes Missing Coverage Covered Lines Changed/Added Lines %
extensions/envelope/signer.go 32 34 94.12%
extensions/envelope/middleware.go 18 21 85.71%
extensions/envelope/crypto.go 23 27 85.19%
Files with Coverage Reduction New Missed Lines %
extensions/token/balance_utxo.go 10 69.61%
testing/mockstub.go 23 51.13%
Totals Coverage Status
Change from base Build 7459099486: -0.05%
Covered Lines: 3996
Relevant Lines: 6987
💛 - Coveralls

Viktor Nosov added 2 commits June 25, 2024 16:42
crypto/signer/verifier
1bc6c8c 
Signed-off-by: Viktor Nosov <[email protected]>
crypto/signer/verifier
ea70e87 
Signed-off-by: Viktor Nosov <[email protected]>
@coveralls
Copy link

coveralls commented Jun 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9663610310

Details

  • 61 of 82 (74.39%) changed or added relevant lines in 4 files are covered.
  • 33 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 57.02%
Changes Missing Coverage Covered Lines Changed/Added Lines %
extensions/envelope/sign.go 23 25 92.0%
extensions/envelope/middleware.go 18 21 85.71%
extensions/envelope/crypto/ed25519.go 11 27 40.74%
Files with Coverage Reduction New Missed Lines %
extensions/token/balance_utxo.go 10 69.61%
testing/mockstub.go 23 51.13%
Totals Coverage Status
Change from base Build 7459099486: -0.2%
Covered Lines: 3984
Relevant Lines: 6987
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9663642859

Details

  • 61 of 82 (74.39%) changed or added relevant lines in 4 files are covered.
  • 33 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 57.034%
Changes Missing Coverage Covered Lines Changed/Added Lines %
extensions/envelope/sign.go 23 25 92.0%
extensions/envelope/middleware.go 18 21 85.71%
extensions/envelope/crypto/ed25519.go 11 27 40.74%
Files with Coverage Reduction New Missed Lines %
extensions/token/balance_utxo.go 10 69.61%
testing/mockstub.go 23 51.13%
Totals Coverage Status
Change from base Build 7459099486: -0.2%
Covered Lines: 3985
Relevant Lines: 6987
💛 - Coveralls

@vitiko vitiko merged commit a1e5a4f into hyperledger-labs:main Jun 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@criro1 criro1 criro1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vitiko @coveralls @criro1 @SiriusPluge