Skip to content

Commit

Permalink
Decimal sep pkg (#33)
Browse files Browse the repository at this point in the history
token.Decimal to separate package
  • Loading branch information
vitiko authored Apr 24, 2023
1 parent 6860e67 commit e038aad
Show file tree
Hide file tree
Showing 32 changed files with 1,267 additions and 1,068 deletions.
3 changes: 2 additions & 1 deletion examples/erc20_utxo/erc20.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (
"github.com/hyperledger-labs/cckit/examples/erc20_utxo/service/config"
"github.com/hyperledger-labs/cckit/extensions/account"
"github.com/hyperledger-labs/cckit/extensions/token"
"github.com/hyperledger-labs/cckit/extensions/token/decimal"
"github.com/hyperledger-labs/cckit/router"
)

Expand All @@ -16,7 +17,7 @@ var (
Name: `SomeToken`,
Symbol: `@`,
Decimals: 2,
TotalSupply: token.NewDecimal(big.NewInt(10000000)),
TotalSupply: decimal.New(big.NewInt(10000000)),
}
)

Expand Down
7 changes: 4 additions & 3 deletions examples/erc20_utxo/erc20_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import (
"github.com/hyperledger-labs/cckit/examples/erc20_utxo/service/config"
"github.com/hyperledger-labs/cckit/extensions/account"
"github.com/hyperledger-labs/cckit/extensions/token"
"github.com/hyperledger-labs/cckit/extensions/token/decimal"
"github.com/hyperledger-labs/cckit/identity"
"github.com/hyperledger-labs/cckit/identity/testdata"
testcc "github.com/hyperledger-labs/cckit/testing"
Expand Down Expand Up @@ -98,13 +99,13 @@ var _ = Describe(`ERC`, func() {
&token.BalanceId{Address: user1Address, Symbol: erc20_utxo.Token.Symbol}),
&token.Balance{}).(*token.Balance)

Expect(b.Amount).To(Equal(token.NewDecimal(big.NewInt(0))))
Expect(b.Amount).To(Equal(decimal.New(big.NewInt(0))))
})

})

Context(`transfer`, func() {
var transferAmount = token.NewDecimal(big.NewInt(100))
var transferAmount = decimal.New(big.NewInt(100))

It(`Disallow to transfer balance by user with zero balance`, func() {
expectcc.ResponseError(
Expand Down Expand Up @@ -150,7 +151,7 @@ var _ = Describe(`ERC`, func() {

Context(`Allowance`, func() {

var allowAmount = token.NewDecimal(big.NewInt(50))
var allowAmount = decimal.New(big.NewInt(50))

It(`Allow to approve amount by owner for spender even if balance is zero`, func() {
a := expectcc.PayloadIs(
Expand Down
3 changes: 2 additions & 1 deletion examples/erc20_utxo/service/allowance/allowance.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (

"github.com/hyperledger-labs/cckit/extensions/account"
"github.com/hyperledger-labs/cckit/extensions/token"
"github.com/hyperledger-labs/cckit/extensions/token/decimal"
"github.com/hyperledger-labs/cckit/router"
"github.com/hyperledger-labs/cckit/state"
)
Expand Down Expand Up @@ -120,7 +121,7 @@ func (s *Service) TransferFrom(ctx router.Context, req *TransferFromRequest) (*T
req.Amount, allowance.Amount, ErrAllowanceInsufficient)
}

allowance.Amount = token.BigIntSubAsDecimal(curAmount, reqAmount)
allowance.Amount = decimal.BigIntSubAsDecimal(curAmount, reqAmount)

// sub from allowance
if err := State(ctx).Put(allowance); err != nil {
Expand Down
8 changes: 4 additions & 4 deletions examples/erc20_utxo/service/allowance/allowance.pb.cc.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

352 changes: 179 additions & 173 deletions examples/erc20_utxo/service/allowance/allowance.pb.go

Large diffs are not rendered by default.

15 changes: 8 additions & 7 deletions examples/erc20_utxo/service/allowance/allowance.proto
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import "google/protobuf/empty.proto";
import "mwitkow/go-proto-validators/validator.proto";

import "token/balance.proto";
import "token/decimal/decimal.proto";

service AllowanceService {
// Returns the remaining number of tokens that spender will be allowed to spend on behalf of owner through transfersender.
Expand Down Expand Up @@ -40,23 +41,23 @@ message ApproveRequest {
string spender = 2 [(validator.field) = {string_not_empty : true}];
string symbol = 3 [(validator.field) = {string_not_empty : true}];
repeated string group = 4;
cckit.extensions.token.Decimal amount = 5 [(validator.field) = {string_not_empty : true}];
cckit.extensions.token.decimal.Decimal amount = 5 [(validator.field) = {string_not_empty : true}];
}

message TransferFromRequest {
string owner = 1 [(validator.field) = {string_not_empty : true}];
string recipient = 2 [(validator.field) = {string_not_empty : true}];
string symbol = 3 [(validator.field) = {string_not_empty : true}];
repeated string group = 4;
cckit.extensions.token.Decimal amount = 5 [(validator.field) = {string_not_empty : true}];
cckit.extensions.token.decimal.Decimal amount = 5 [(validator.field) = {string_not_empty : true}];
}

message TransferFromResponse {
string owner = 1;
string recipient = 2;
string symbol = 3 ;
repeated string group = 4;
cckit.extensions.token.Decimal amount = 5;
cckit.extensions.token.decimal.Decimal amount = 5;
}

// Id: Allowance identifier
Expand All @@ -73,15 +74,15 @@ message Allowance {
string spender = 2;
string symbol = 3 ;
repeated string group = 4;
cckit.extensions.token.Decimal amount = 5;
cckit.extensions.token.decimal.Decimal amount = 5;
}

message Operation {
string owner = 1;
string spender = 2;
string symbol = 3 ;
repeated string group = 4;
cckit.extensions.token.Decimal amount = 5;
cckit.extensions.token.decimal.Decimal amount = 5;
}

// List:
Expand All @@ -95,7 +96,7 @@ message Approved {
string spender = 2;
string symbol = 3 ;
repeated string group = 4;
cckit.extensions.token.Decimal amount = 5;
cckit.extensions.token.decimal.Decimal amount = 5;
}

// Event: TransferredFrom event is emitted when TransferFrom method has been invoked
Expand All @@ -105,5 +106,5 @@ message TransferredFrom {
string recipient = 3;
string symbol = 4 ;
repeated string group = 5;
cckit.extensions.token.Decimal amount = 6;
cckit.extensions.token.decimal.Decimal amount = 6;
}
28 changes: 14 additions & 14 deletions examples/erc20_utxo/service/allowance/allowance.swagger.json
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@
}
},
"amount": {
"$ref": "#/definitions/tokenDecimal"
"$ref": "#/definitions/decimalDecimal"
}
},
"title": "State: Allowance"
Expand All @@ -156,7 +156,19 @@
}
},
"amount": {
"$ref": "#/definitions/tokenDecimal"
"$ref": "#/definitions/decimalDecimal"
}
}
},
"decimalDecimal": {
"type": "object",
"properties": {
"scale": {
"type": "integer",
"format": "int32"
},
"value": {
"type": "string"
}
}
},
Expand Down Expand Up @@ -192,18 +204,6 @@
}
}
}
},
"tokenDecimal": {
"type": "object",
"properties": {
"scale": {
"type": "integer",
"format": "int32"
},
"value": {
"type": "string"
}
}
}
}
}

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions examples/erc20_utxo/service/config/config.pb.cc.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

39 changes: 20 additions & 19 deletions examples/erc20_utxo/service/config/config.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions examples/erc20_utxo/service/config/config.proto
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ package examples.erc20_utxo.service.config;
import "google/api/annotations.proto";
import "google/protobuf/empty.proto";

import "token/balance.proto";
import "token/decimal/decimal.proto";

// ERC-20 Config getters
service ConfigService {
Expand Down Expand Up @@ -54,5 +54,5 @@ message DecimalsResponse {
}

message TotalSupplyResponse {
cckit.extensions.token.Decimal total_supply = 1;
cckit.extensions.token.decimal.Decimal total_supply = 1;
}
26 changes: 13 additions & 13 deletions examples/erc20_utxo/service/config/config.swagger.json
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,19 @@
"type": "object",
"properties": {
"total_supply": {
"$ref": "#/definitions/tokenDecimal"
"$ref": "#/definitions/decimalDecimal"
}
}
},
"decimalDecimal": {
"type": "object",
"properties": {
"scale": {
"type": "integer",
"format": "int32"
},
"value": {
"type": "string"
}
}
},
Expand Down Expand Up @@ -170,18 +182,6 @@
}
}
}
},
"tokenDecimal": {
"type": "object",
"properties": {
"scale": {
"type": "integer",
"format": "int32"
},
"value": {
"type": "string"
}
}
}
}
}
2 changes: 1 addition & 1 deletion examples/erc20_utxo/service/config/config.validator.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions extensions/token/balance.pb.cc.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit e038aad

Please sign in to comment.