Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.x] Overhaul the blog post authors feature #1782

Merged
merged 93 commits into from
Jul 7, 2024
Merged

[2.x] Overhaul the blog post authors feature #1782

merged 93 commits into from
Jul 7, 2024

Commits on Jul 5, 2024

  1. Update class documentation

    @caendesilva
    caendesilva committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    f369a3a View commit details
    Browse the repository at this point in the history

  2. Create HasKernelData.php

    @caendesilva
    caendesilva committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    576f94f View commit details
    Browse the repository at this point in the history

  3. Use HasKernelData trait

    @caendesilva
    caendesilva committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    eba7450 View commit details
    Browse the repository at this point in the history

  4. Update class description

    @caendesilva
    caendesilva committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    863ce8a View commit details
    Browse the repository at this point in the history

  5. Add authors array to the kernel

    @caendesilva
    caendesilva committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    90027fd View commit details
    Browse the repository at this point in the history

  6. Change array to Collection

    @caendesilva
    caendesilva committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    88ef930 View commit details
    Browse the repository at this point in the history

  7. Remove disallowed initialiser

    @caendesilva
    caendesilva committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    7de5640 View commit details
    Browse the repository at this point in the history

  8. Annotate the collection generics

    @caendesilva
    caendesilva committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    25d03bd View commit details
    Browse the repository at this point in the history

  9. Document the property

    @caendesilva
    caendesilva committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    d40d8ed View commit details
    Browse the repository at this point in the history

  10. Add authors getter

    @caendesilva
    caendesilva committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    d23a697 View commit details
    Browse the repository at this point in the history

  11. Class PostAuthor implements SerializableContract

    @caendesilva
    caendesilva committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    9a4524f View commit details
    Browse the repository at this point in the history

  12. Use the Serializable trait

    @caendesilva
    caendesilva committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    3b5bf3a View commit details
    Browse the repository at this point in the history

  13. Implement the toArray method

    @caendesilva
    caendesilva committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    11a8f36 View commit details
    Browse the repository at this point in the history

  14. Test author serialization

    @caendesilva
    caendesilva committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    d21b4f3 View commit details
    Browse the repository at this point in the history

  15. Normalize formatting

    @caendesilva
    caendesilva committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    0b2b1e7 View commit details
    Browse the repository at this point in the history

  16. Update kernel test to test the author access

    @caendesilva
    caendesilva committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    142bdb5 View commit details
    Browse the repository at this point in the history

  17. Null coalesce assign the authors data

    @caendesilva
    caendesilva committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    6cd24fc View commit details
    Browse the repository at this point in the history

  18. Add additional kernel author tests

    @caendesilva
    caendesilva committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    6c55b2d View commit details
    Browse the repository at this point in the history

  19. Replace qualifiers with an import

    @caendesilva
    caendesilva committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    ad535d6 View commit details
    Browse the repository at this point in the history

  20. Reorder tests

    @caendesilva
    caendesilva committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    64f3e36 View commit details
    Browse the repository at this point in the history

  21. Assert same for scalar values

    @caendesilva
    caendesilva committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    c36bcaf View commit details
    Browse the repository at this point in the history

  22. Filter empty fields from serialization

    @caendesilva
    caendesilva committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    7a90a2a View commit details
    Browse the repository at this point in the history

  23. Add semantic testing helper to reset the kernel

    @caendesilva
    caendesilva committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    0811dc9 View commit details
    Browse the repository at this point in the history

  24. Move author discovery logic to kernel

    @caendesilva
    caendesilva committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    82ac9e3 View commit details
    Browse the repository at this point in the history

  25. Defer setting the authors property until the next try

    @caendesilva
    caendesilva committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    701fbbc View commit details
    Browse the repository at this point in the history

  26. Remove getter prefix from kernel author accessor 

     We don't use this for other kernel collections
    @caendesilva
    caendesilva committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    f02091d View commit details
    Browse the repository at this point in the history

  27. Annotate the authors method

    @caendesilva
    caendesilva committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    f445f24 View commit details
    Browse the repository at this point in the history

  28. Clean up formatting

    @caendesilva
    caendesilva committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    84289ec View commit details
    Browse the repository at this point in the history

  29. Test authors property is not written until there are authors defined

    @caendesilva
    caendesilva committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    d82a8f4 View commit details
    Browse the repository at this point in the history

  30. Merge branch '2.x-dev' into overhaul-the-authors-feature

    @caendesilva
    caendesilva committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    4c5b761 View commit details
    Browse the repository at this point in the history

  31. Return the empty collection instead of creating a new one

    @caendesilva
    caendesilva committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    5b06ff4 View commit details
    Browse the repository at this point in the history

  32. Remove null coalesce part of evaluated assignment

    @caendesilva
    caendesilva committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    8be7284 View commit details
    Browse the repository at this point in the history

  33. Extract helper method for parsing the authors

    @caendesilva
    caendesilva committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    aff2083 View commit details
    Browse the repository at this point in the history

  34. Update the blog post author configuration to be keyed by the usernames 

    > We may also want to consider keying the array, to make the username relationship more explicit. This means we would do this for v2.

See #1778
    @caendesilva
    caendesilva committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    7a230e9 View commit details
    Browse the repository at this point in the history

  35. Update the kernel array representation to include the site authors

    @caendesilva
    caendesilva committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    1faaa16 View commit details
    Browse the repository at this point in the history

  36. Clarify documentation

    @caendesilva
    caendesilva committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    8891c8f View commit details
    Browse the repository at this point in the history

  37. Add base constructor tests

    @caendesilva
    caendesilva committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    4d5a936 View commit details
    Browse the repository at this point in the history

  38. Update post author name to fall back to username at construct time

    @caendesilva
    caendesilva committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    0dfb841 View commit details
    Browse the repository at this point in the history

  39. Return keyed author array

    @caendesilva
    caendesilva committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    96d3969 View commit details
    Browse the repository at this point in the history

  40. Revert "Return keyed author array" 

    This reverts commit beef1acd94803618bea66a18a636effb3ec1d0c9.
    @caendesilva
    caendesilva committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    0240675 View commit details
    Browse the repository at this point in the history

  41. Merge branch '2.x-dev' into overhaul-the-authors-feature

    @caendesilva
    caendesilva committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    411348b View commit details
    Browse the repository at this point in the history

  42. Update authors to support setting a biography

    @caendesilva
    caendesilva committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    3151b64 View commit details
    Browse the repository at this point in the history

  43. Update authors to support setting social media handles

    @caendesilva
    caendesilva committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    e370dc7 View commit details
    Browse the repository at this point in the history

  44. Update authors to support setting avatars

    @caendesilva
    caendesilva committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    4425913 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2024

  1. Clarify code documentation

    @caendesilva
    caendesilva committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    da1680e View commit details
    Browse the repository at this point in the history

  2. Get authors by array key

    @caendesilva
    caendesilva committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    bcebbc5 View commit details
    Browse the repository at this point in the history

  3. Make socials readonly

    @caendesilva
    caendesilva committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    c56e92d View commit details
    Browse the repository at this point in the history

  4. Remove initializer from readonly field

    @caendesilva
    caendesilva committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    6bfef3b View commit details
    Browse the repository at this point in the history

  5. Split comma-separated values into multiple lines

    @caendesilva
    caendesilva committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    74b080f View commit details
    Browse the repository at this point in the history

  6. Introduce local variables

    @caendesilva
    caendesilva committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    0385586 View commit details
    Browse the repository at this point in the history

  7. Join comma-separated values into a single line

    @caendesilva
    caendesilva committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    0a49471 View commit details
    Browse the repository at this point in the history

  8. Revert "Join comma-separated values into a single line" 

    This reverts commit 0a49471.
    @caendesilva
    caendesilva committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    9b11c94 View commit details
    Browse the repository at this point in the history

  9. Add name identifiers to arguments

    @caendesilva
    caendesilva committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    abd618b View commit details
    Browse the repository at this point in the history

  10. Extract helper method

    @caendesilva
    caendesilva committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    dcae0af View commit details
    Browse the repository at this point in the history

  11. Split comma-separated values into multiple lines

    @caendesilva
    caendesilva committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    67d4b9e View commit details
    Browse the repository at this point in the history

  12. Convert to keyed array

    @caendesilva
    caendesilva committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    dd70f87 View commit details
    Browse the repository at this point in the history

  13. Inline local variables

    @caendesilva
    caendesilva committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    9b4dd57 View commit details
    Browse the repository at this point in the history

  14. Fix formatting

    @caendesilva
    caendesilva committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    f55ffbb View commit details
    Browse the repository at this point in the history

  15. Add ArrayShape to PHPDoc

    @caendesilva
    caendesilva committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    d5454c2 View commit details
    Browse the repository at this point in the history

  16. Test can create author model with full details argument unpacking

    @caendesilva
    caendesilva committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    b0a5c34 View commit details
    Browse the repository at this point in the history

  17. Remove faulty legacy argument from test

    @caendesilva
    caendesilva committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    d29744c View commit details
    Browse the repository at this point in the history

  18. Support setting all arguments through the array constructor

    @caendesilva
    caendesilva committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    5d6ddab View commit details
    Browse the repository at this point in the history

  19. Update outdated ArrayShape annotation

    @caendesilva
    caendesilva committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    1baa0c3 View commit details
    Browse the repository at this point in the history

  20. Deprecate the PostAuthor::getName() method 

    This is not needed as the name property can be accessed directly
    @caendesilva
    caendesilva committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    2f54b9f View commit details
    Browse the repository at this point in the history

  21. Replace with '$this->name'

    @caendesilva
    caendesilva committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    76ab3ab View commit details
    Browse the repository at this point in the history

  22. Add newline

    @caendesilva
    caendesilva committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    a20350a View commit details
    Browse the repository at this point in the history

  23. Test that post authors can be set in the Yaml config

    @caendesilva
    caendesilva committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    369a7e6 View commit details
    Browse the repository at this point in the history

  24. Draft method to parse authors

    @caendesilva
    caendesilva committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    2ad343a View commit details
    Browse the repository at this point in the history

  25. If namespace is for Hyde and authors are set then parse them

    @caendesilva
    caendesilva committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    8115c62 View commit details
    Browse the repository at this point in the history

  26. Annotate the helper method generics

    @caendesilva
    caendesilva committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    2191c88 View commit details
    Browse the repository at this point in the history

  27. Implement Yaml configuration author parsing 

    Fixes #1719
    @caendesilva
    caendesilva committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    ff2ddfc View commit details
    Browse the repository at this point in the history

  28. Draft test for Yaml config authors being merged with the PHP config

    @caendesilva
    caendesilva committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    208c848 View commit details
    Browse the repository at this point in the history

  29. Revert "Draft test for Yaml config authors being merged with the PHP … 

    …config"

This reverts commit 1a86dc454f3e34c388645511b06f4b779fb48c2a. See https://github.com/hydephp/develop/pull/1782/files#r1667340453
    @caendesilva
    caendesilva committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    5f1e2d3 View commit details
    Browse the repository at this point in the history

  30. Add todo

    @caendesilva
    caendesilva committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    896860f View commit details
    Browse the repository at this point in the history

  31. Merge branch '2.x-dev' into overhaul-the-authors-feature

    @caendesilva
    caendesilva committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    3d41214 View commit details
    Browse the repository at this point in the history

  32. Merge branch '2.x-dev' into overhaul-the-authors-feature

    @caendesilva
    caendesilva committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    afba5ca View commit details
    Browse the repository at this point in the history

  33. Merge branch '2.x-dev' into overhaul-the-authors-feature

    @caendesilva
    caendesilva committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    9399aad View commit details
    Browse the repository at this point in the history

  34. Use automatic array serialisation 

    Uses logic from #1793
    @caendesilva
    caendesilva committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    a98d5be View commit details
    Browse the repository at this point in the history

  35. Test to array method serializes all data

    @caendesilva
    caendesilva committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    ad35ed3 View commit details
    Browse the repository at this point in the history

  36. Move down test method

    @caendesilva
    caendesilva committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    b7951a2 View commit details
    Browse the repository at this point in the history

  37. Add $author->getPosts() method to get all the author's posts

    @caendesilva
    caendesilva committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    86b5de9 View commit details
    Browse the repository at this point in the history

  38. Rename helper method to be clearer

    @caendesilva
    caendesilva committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    b3f9af6 View commit details
    Browse the repository at this point in the history

  39. Merge getOrCreate method into the get method

    @caendesilva
    caendesilva committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    5fb193e View commit details
    Browse the repository at this point in the history

  40. Revert "Merge getOrCreate method into the get method" 

    This reverts commit 5fb193e.
    @caendesilva
    caendesilva committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    a08fb50 View commit details
    Browse the repository at this point in the history

  41. Split out creator methods 

    https://claude.ai/chat/d82c5409-76af-4cf4-b88b-fdd74edd7728
    @caendesilva
    caendesilva committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    3f8e6a3 View commit details
    Browse the repository at this point in the history

  42. Revert "Split out creator methods" 

    This reverts commit 3f8e6a3.
    @caendesilva
    caendesilva committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    bef60ad View commit details
    Browse the repository at this point in the history

  43. Merge branch '2.x-dev' into overhaul-the-authors-feature

    @caendesilva
    caendesilva committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    8730fd3 View commit details
    Browse the repository at this point in the history

  44. Merge branch '2.x-dev' into overhaul-the-authors-feature

    @caendesilva
    caendesilva committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    5ba4500 View commit details
    Browse the repository at this point in the history

  45. Remove deprecated PostAuthor::getName() method

    @caendesilva
    caendesilva committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    453a6c4 View commit details
    Browse the repository at this point in the history

  46. Add todo 

    See https://github.com/hydephp/develop/pull/1782/files#r1667091929
    @caendesilva
    caendesilva committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    af6fa43 View commit details
    Browse the repository at this point in the history

  47. Use a collect call instead of new collection

    @caendesilva
    caendesilva committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    f6a4725 View commit details
    Browse the repository at this point in the history

  48. Update RELEASE_NOTES.md

    @caendesilva
    caendesilva committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    d4f7d95 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2024

  1. Merge branch '2.x-dev' into overhaul-the-authors-feature

    @caendesilva
    caendesilva authored Jul 7, 2024
    Configuration menu
    Copy the full SHA
    8f1134d View commit details
    Browse the repository at this point in the history