Merge pull request #1962 from hydephp/test-cleanup

Internal: Test code refactors and cleanup
hydephp · Sep 10, 2024 · 7e4b929 · 7e4b929
2 parents 9b0dabd + 2e048b5
commit 7e4b929
Show file tree

Hide file tree

Showing 3 changed files with 80 additions and 99 deletions.
diff --git a/packages/framework/tests/Feature/MetadataHelperTest.php b/packages/framework/tests/Feature/MetadataHelperTest.php
diff --git a/packages/framework/tests/Unit/MetaFacadeTest.php b/packages/framework/tests/Unit/MetaFacadeTest.php
@@ -0,0 +1,64 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Hyde\Framework\Testing\Unit;
+
+use Hyde\Facades\Meta;
+use Hyde\Framework\Features\Metadata\GlobalMetadataBag;
+use Hyde\Testing\UnitTestCase;
+
+/**
+ * @covers \Hyde\Facades\Meta
+ */
+class MetaFacadeTest extends UnitTestCase
+{
+    protected static bool $needsKernel = true;
+    protected static bool $needsConfig = true;
+    protected static bool $needsRender = true;
+
+    public function testNameMethodReturnsAValidHtmlMetaString()
+    {
+        $this->assertSame('<meta name="foo" content="bar">', (string) Meta::name('foo', 'bar'));
+    }
+
+    public function testPropertyMethodReturnsAValidHtmlMetaString()
+    {
+        $this->assertSame('<meta property="og:foo" content="bar">', (string) Meta::property('foo', 'bar'));
+    }
+
+    public function testPropertyMethodAcceptsPropertyWithOgPrefix()
+    {
+        $this->assertSame('<meta property="og:foo" content="bar">', (string) Meta::property('og:foo', 'bar'));
+    }
+
+    public function testPropertyMethodAcceptsPropertyWithoutOgPrefix()
+    {
+        $this->assertSame('<meta property="og:foo" content="bar">', (string) Meta::property('foo', 'bar'));
+    }
+
+    public function testLinkMethodReturnsAValidHtmlLinkString()
+    {
+        $this->assertSame('<link rel="foo" href="bar">', (string) Meta::link('foo', 'bar'));
+    }
+
+    public function testLinkMethodReturnsAValidHtmlLinkStringWithAttributes()
+    {
+        $this->assertSame('<link rel="foo" href="bar" title="baz">', (string) Meta::link('foo', 'bar', ['title' => 'baz']));
+    }
+
+    public function testLinkMethodReturnsAValidHtmlLinkStringWithMultipleAttributes()
+    {
+        $this->assertSame('<link rel="foo" href="bar" title="baz" type="text/css">', (string) Meta::link('foo', 'bar', ['title' => 'baz', 'type' => 'text/css']));
+    }
+
+    public function testGetMethodReturnsGlobalMetadataBag()
+    {
+        $this->assertEquals(Meta::get(), GlobalMetadataBag::make());
+    }
+
+    public function testRenderMethodRendersGlobalMetadataBag()
+    {
+        $this->assertSame(Meta::render(), GlobalMetadataBag::make()->render());
+    }
+}
diff --git a/...sts/Feature/PageModelConstructorsTest.php → ...ework/tests/Unit/PageModelParsingTest.php b/...sts/Feature/PageModelConstructorsTest.php → ...ework/tests/Unit/PageModelParsingTest.php
@@ -2,13 +2,12 @@
 
 declare(strict_types=1);
 
-namespace Hyde\Framework\Testing\Feature;
+namespace Hyde\Framework\Testing\Unit;
 
-use Hyde\Facades\Filesystem;
-use Hyde\Hyde;
+use Hyde\Testing\UnitTestCase;
 use Hyde\Pages\DocumentationPage;
 use Hyde\Pages\MarkdownPage;
-use Hyde\Testing\TestCase;
+use Hyde\Testing\CreatesTemporaryFiles;
 
 /**
  * Test the constructor actions and schema constructors for page models.
@@ -19,8 +18,18 @@
  * @covers \Hyde\Framework\Factories\HydePageDataFactory
  * @covers \Hyde\Framework\Factories\BlogPostDataFactory
  */
-class PageModelConstructorsTest extends TestCase
+class PageModelParsingTest extends UnitTestCase
 {
+    use CreatesTemporaryFiles;
+
+    protected static bool $needsKernel = true;
+    protected static bool $needsConfig = true;
+
+    protected function tearDown(): void
+    {
+        $this->cleanUpFilesystem();
+    }
+
     public function testDynamicDataConstructorCanFindTitleFromFrontMatter()
     {
         $this->markdown('_pages/foo.md', '# Foo Bar', ['title' => 'My Title']);
@@ -55,13 +64,10 @@ public function testDocumentationPageParserCanGetGroupFromFrontMatter()
 
     public function testDocumentationPageParserCanGetGroupAutomaticallyFromNestedPage()
     {
-        mkdir(Hyde::path('_docs/foo'));
-        touch(Hyde::path('_docs/foo/bar.md'));
+        $this->directory('_docs/foo');
+        $this->file('_docs/foo/bar.md');
 
         $page = DocumentationPage::parse('foo/bar');
         $this->assertSame('foo', $page->navigationMenuGroup());
-
-        Filesystem::unlink('_docs/foo/bar.md');
-        rmdir(Hyde::path('_docs/foo'));
     }
 }