Skip to content
This repository has been archived by the owner on Jul 27, 2023. It is now read-only.

Added automatic OHLCV fetcher for crypto exchanges #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added automatic OHLCV fetcher for crypto exchanges #14

wants to merge 1 commit into from

Conversation

AlconDivino
Copy link
Contributor

Added crypto_data_loader.py
New Feature: fetch crypto data directly from exchange

Added crypto_data_loader.py
New Feature: fetch crypto data directly from exchange
@bitnom
Copy link

bitnom commented Mar 25, 2019

Added crypto_data_loader.py
New Feature: fetch crypto data directly from exchange

I already did that too lol. Check to see which one is better.

@bitnom
Copy link

bitnom commented Mar 25, 2019

Added crypto_data_loader.py
New Feature: fetch crypto data directly from exchange

Mine is slightly better. Please let mine get pulled this time so I can get on the contrib. It's this one #11 for this file: https://github.com/TensorTom/Stock-Prediction-Models/blob/master/dataset/downloader_crypto.py

@AlconDivino
Copy link
Contributor Author

Yeah just added the one directly to my evolution_bayesian.py file. My crypto loader passes the data as pandas.Dataframe directly to the script and not to a CSV file. Also my file is based on yours :D

@bitnom
Copy link

bitnom commented Mar 25, 2019

Yeah just added the one directly to my evolution_bayesian.py file. My crypto loader passes the data as pandas.Dataframe directly to the script and not to a CSV file. Also my file is based on yours :D

That's good. Just add an option so user can switch between your loader and flat csv so that my loader still works. It's good to have a CLI tool for it. Mine is an argv script.

@AlconDivino
Copy link
Contributor Author

Yeah they just have to comment out 1 line and recommend the original one. No worries there

@bitnom
Copy link

bitnom commented Mar 25, 2019

Yeah they just have to comment out 1 line and recommend the original one. No worries there

Check my latest commits on my fork. Worked that out and also improved the structure.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants