Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace theme variables with CSS variables #344

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Replace theme variables with CSS variables #344

merged 2 commits into from
Sep 12, 2024

Conversation

yurabakhtin
Copy link
Contributor

@marc-farre
Copy link
Contributor

@yurabakhtin Thanks.
What do you think about deleting the CustomPageInlineStyle widget and replace it with an asset to load a CSS file instead?

@yurabakhtin
Copy link
Contributor Author

What do you think about deleting the CustomPageInlineStyle widget and replace it with an asset to load a CSS file instead?

@marc-farre Good idea, thanks! Done in the commit 7e07454.

@marc-farre
Copy link
Contributor

@yurabakhtin Thanks!

@luke- luke- merged commit d6d2545 into master Sep 12, 2024
11 checks passed
@luke- luke- deleted the enh/360-replace-theme-variables branch September 12, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luke- luke- luke- approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yurabakhtin @marc-farre @luke-