Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Splinter exporters (#555) #736

Merged
merged 4 commits into from
Feb 3, 2023
Merged

Conversation

Allanbeddouk
Copy link
Contributor

Add Splinter model in exporters.

Contributions related to @michaelbenayoun 's checklist from issue #555

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Feb 1, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Contributor

@fxmarty fxmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

tests/exporters/exporters_utils.py Show resolved Hide resolved
Copy link
Member

@michaelbenayoun michaelbenayoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once @fxmarty has been addressed and the tests pass.

Copy link
Contributor

@fxmarty fxmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, the remaining two errors are unrelated, so merging!

@fxmarty fxmarty merged commit f0029ba into huggingface:main Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants