Merge pull request #129 from huff-language/reverts-on-erc721

huff-language · Sep 1, 2023 · 4e2c9bd · 4e2c9bd
2 parents 3211a84 + 55eec6e
commit 4e2c9bd
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 9 deletions.
diff --git a/src/tokens/ERC721.huff b/src/tokens/ERC721.huff
@@ -104,6 +104,10 @@
 #define macro BALANCE_OF() = takes (0) returns (0) {
     NON_PAYABLE()                                       // []
     0x04 calldataload                                   // [account]
+    // revert if account is zero address
+    dup1 continue jumpi 
+    ZERO_ADDRESS(0x00)
+    continue:
     [BALANCE_LOCATION] LOAD_ELEMENT_FROM_KEYS(0x00)     // [balance]
     0x00 mstore                                         // []
     0x20 0x00 return                                    // []
@@ -114,6 +118,10 @@
 #define macro OWNER_OF() = takes (0) returns (0) {
     0x04 calldataload                               // [tokenId]
     [OWNER_LOCATION] LOAD_ELEMENT_FROM_KEYS(0x00)   // [owner]
+    // revert if owner is zero address/not minted
+    dup1 continue jumpi
+    NOT_MINTED(0x00)
+    continue:
     0x00 mstore                                     // []
     0x20 0x00 return                                // []
 }

diff --git a/test/tokens/ERC721.t.sol b/test/tokens/ERC721.t.sol
@@ -118,7 +118,10 @@ contract ERC721Test is Test {
         // We can't burn a token we don't have
         assertEq(token.balanceOf(address(this)), 0);
         assertEq(token.getApproved(1337), address(0));
+
+        vm.expectRevert(bytes("NOT_MINTED"));
         assertEq(token.ownerOf(1337), address(0));
+
         vm.expectRevert(bytes("NOT_MINTED"));
         token.burn(1337);
 
@@ -136,6 +139,8 @@ contract ERC721Test is Test {
         token.burn(1337);
         assertEq(token.balanceOf(address(this)), 0);
         assertEq(token.getApproved(1337), address(0));
+
+        vm.expectRevert(bytes("NOT_MINTED"));
         assertEq(token.ownerOf(1337), address(0));
 
         vm.expectRevert(bytes("NOT_MINTED"));
@@ -459,8 +464,8 @@ contract ERC721Test is Test {
     }
 
     function testBalanceOfZeroAddress() public {
+        vm.expectRevert(bytes("ZERO_ADDRESS"));
         uint256 bal = token.balanceOf(address(0));
-        assertEq(0, bal);
     }
 
     // function testFailOwnerOfUnminted() public view {
@@ -484,12 +489,8 @@ contract ERC721Test is Test {
 
         assertEq(token.balanceOf(to), 0);
 
-        // vm.expectRevert("NOT_MINTED");
-        // token.ownerOf(id);
-
-        // vm.expectRevert("NOT_MINTED");
-        address owner = token.ownerOf(id);
-        assertEq(owner, address(0));
+        vm.expectRevert(bytes("NOT_MINTED"));
+        token.ownerOf(id);
     }
 
     function testApprove(address to, uint256 id) public {
@@ -512,7 +513,7 @@ contract ERC721Test is Test {
         assertEq(token.balanceOf(address(this)), 0);
         assertEq(token.getApproved(id), address(0));
 
-        // vm.expectRevert("NOT_MINTED");
+        vm.expectRevert(bytes("NOT_MINTED"));
         address owner = token.ownerOf(id);
         assertEq(owner, address(0));
     }
@@ -819,7 +820,7 @@ contract ERC721Test is Test {
     }
 
     function testOwnerOfUnminted(uint256 id) public {
+        vm.expectRevert(bytes("NOT_MINTED"));
         address owner = token.ownerOf(id);
-        assertEq(owner, address(0));
     }
 }