Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurations for donors label and button urls #1223

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

edlu77
Copy link
Collaborator

@edlu77 edlu77 commented Jan 26, 2024

@edlu77 edlu77 self-assigned this Jan 26, 2024
Copy link

github-actions bot commented Jan 26, 2024

🚀 Preview Deploy Report Updated

✅ Successfully deployed preview here

Copy link
Member

@bherr2 bherr2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are the default URL set? Also, need to add documentation to the EMBEDDING.md about the new inputs.

@bherr2
Copy link
Member

bherr2 commented Jan 30, 2024

What kind of speed improvements are you seeing? Test load times with dataSources + use-remote-api=true vs dataSource + use-remote-api=false. Should give you an indication of the speed up we'll receive.

@edlu77
Copy link
Collaborator Author

edlu77 commented Jan 30, 2024

What kind of speed improvements are you seeing? Test load times with dataSources + use-remote-api=true vs dataSource + use-remote-api=false. Should give you an indication of the speed up we'll receive.

Was this supposed to be in the other PR? 😅

Anyway I tested it, it doesn't really seem to be making much difference. Takes basically the same amount of time to load as before...

@edlu77
Copy link
Collaborator Author

edlu77 commented Jan 30, 2024

Where are the default URL set? Also, need to add documentation to the EMBEDDING.md about the new inputs.

Default URLs are set here: https://github.com/hubmapconsortium/ccf-ui/blob/develop/projects/ccf-organ-info/src/app/modules/link-cards/link-cards.component.ts

The inputs to the web component override buttonUrl

Copy link

sonarcloud bot commented Jan 30, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@axdanbol axdanbol merged commit 08236d3 into develop Feb 5, 2024
2 of 3 checks passed
@axdanbol axdanbol deleted the organ-info-sennet-label-url branch February 5, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants