Replace async-std with smol crates #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It would be nice to be able to use this in environments where I use smol. However this crate imports the async-std crate for I/O. This commit partially replaces async-std with the equivalent combinators from futures-lite and async-io, two smol crates that async-std depends on anyways. The task spawn is still left in, as replacing it will be controversial. Signed-off-by: John Nunley <[email protected]>
This is a placeholder until I figure out how to actually handle this without the global executor. Signed-off-by: John Nunley <[email protected]>
This helps cargo-add work better Signed-off-by: John Nunley <[email protected]>
|
@joshtriplett Are you the primary maintainer of this crate? If so, can you review this? |
|
"primary maintainer" no, but I'm one of the maintainers. Reducing dependencies seems reasonable to me. That will let more things build in parallel, and as you said, allow using this in environments that don't need all of the dependencies. |
|
Thanks for merging!
Hmm, is there someone better I should request reviews from in the future? |
|
Async-h1, along with the other http-rs crates, is not generally actively maintained, so Josh is as good a tag as there is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be nice to be able to use this in environments where I use
smol. However this crate imports the async-std crate for I/O. This
commit partially replaces async-std with the equivalent combinators from
futures-lite and async-io, two smol crates that async-std depends on
anyways.
The task spawn is still left in, as replacing it will be controversial. Thus far I've just replaced it with
async-global-executor, which is whatasync-stduses anyways. This is a placeholder until we can discuss what the best way of not using a global executor is.