This repository has been archived by the owner on Jun 17, 2024. It is now read-only.
feature(monk): pass options to monk .find() calls #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the user to easily apply limit and sort options along with various other Mongo options to the .find() query via the standard API that monk exposes.
|
@benbrown Hey there, I know this repo probably doesn't get as much love as it used to, but is there anything we can do to help get some of these open PRs across the finish line? This one in particular is a big deal if you are storing any other data in the MongoDB instance and need to query it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the user to easily apply limit and sort options along with various other Mongo options to the
.find()query via the standard API that monk exposes.I added a test, but it is rather unclear how the tests for this project are supposed to work and I could never get more than the first two to pass. I'd be happy to revisit the tests if you can tell me what I need to do to get them running.
Closes #39