Replace Listener with Coroutine Flow in BackgroundManager

app/src/main/java/io/horizontalsystems/bankwallet/core/App.kt

@@ -26,7 +26,6 @@ import io.horizontalsystems.bankwallet.core.managers.AccountCleaner
 import io.horizontalsystems.bankwallet.core.managers.AccountManager
 import io.horizontalsystems.bankwallet.core.managers.AdapterManager
 import io.horizontalsystems.bankwallet.core.managers.AppVersionManager
-import io.horizontalsystems.bankwallet.core.managers.BackgroundStateChangeListener
 import io.horizontalsystems.bankwallet.core.managers.BackupManager
 import io.horizontalsystems.bankwallet.core.managers.BalanceHiddenManager
 import io.horizontalsystems.bankwallet.core.managers.BaseTokenManager
@@ -141,7 +140,6 @@ class App : CoreApp(), WorkConfiguration.Provider, ImageLoaderFactory {
         lateinit var btcBlockchainManager: BtcBlockchainManager
         lateinit var wordsManager: WordsManager
         lateinit var networkManager: INetworkManager
-        lateinit var backgroundStateChangeListener: BackgroundStateChangeListener
         lateinit var appConfigProvider: AppConfigProvider
         lateinit var adapterManager: IAdapterManager
         lateinit var transactionAdapterManager: TransactionAdapterManager
@@ -358,13 +356,11 @@ class App : CoreApp(), WorkConfiguration.Provider, ImageLoaderFactory {
         pinComponent = PinComponent(
             pinSettingsStorage = pinSettingsStorage,
             userManager = userManager,
-            pinDbStorage = PinDbStorage(appDatabase.pinDao())
+            pinDbStorage = PinDbStorage(appDatabase.pinDao()),
+            backgroundManager = backgroundManager
         )
 
-        statsManager = StatsManager(appDatabase.statsDao(), localStorage, marketKit, appConfigProvider)
-        backgroundStateChangeListener = BackgroundStateChangeListener(pinComponent, statsManager).apply {
-            backgroundManager.registerListener(this)
-        }
+        statsManager = StatsManager(appDatabase.statsDao(), localStorage, marketKit, appConfigProvider, backgroundManager)
 
         rateAppManager = RateAppManager(walletManager, adapterManager, localStorage)
 

app/src/main/java/io/horizontalsystems/bankwallet/core/adapters/BitcoinBaseAdapter.kt

@@ -32,6 +32,7 @@ import io.horizontalsystems.bitcoincore.storage.FullTransaction
 import io.horizontalsystems.bitcoincore.storage.UnspentOutput
 import io.horizontalsystems.bitcoincore.storage.UnspentOutputInfo
 import io.horizontalsystems.core.BackgroundManager
+import io.horizontalsystems.core.BackgroundManagerState
 import io.horizontalsystems.hodler.HodlerOutputData
 import io.horizontalsystems.hodler.HodlerPlugin
 import io.horizontalsystems.marketkit.models.Token
@@ -40,35 +41,28 @@ import io.reactivex.Flowable
 import io.reactivex.Observable
 import io.reactivex.Single
 import io.reactivex.subjects.PublishSubject
+import kotlinx.coroutines.CoroutineScope
+import kotlinx.coroutines.Dispatchers
+import kotlinx.coroutines.SupervisorJob
+import kotlinx.coroutines.cancel
+import kotlinx.coroutines.launch
 import java.math.BigDecimal
 import java.math.RoundingMode
 import java.util.Date
 
 abstract class BitcoinBaseAdapter(
     open val kit: AbstractKit,
     open val syncMode: BitcoinCore.SyncMode,
-    backgroundManager: BackgroundManager,
+    private val backgroundManager: BackgroundManager,
     val wallet: Wallet,
     private val confirmationsThreshold: Int,
     protected val decimal: Int = 8
-) : IAdapter, ITransactionsAdapter, IBalanceAdapter, IReceiveAdapter, BackgroundManager.Listener {
+) : IAdapter, ITransactionsAdapter, IBalanceAdapter, IReceiveAdapter {
 
-    init {
-        backgroundManager.registerListener(this)
-    }
+    private val scope = CoroutineScope(SupervisorJob() + Dispatchers.IO)
 
     abstract val satoshisInBitcoin: BigDecimal
 
-    override fun willEnterForeground() {
-        super.willEnterForeground()
-        kit.onEnterForeground()
-    }
-
-    override fun didEnterBackground() {
-        super.didEnterBackground()
-        kit.onEnterBackground()
-    }
-
     //
     // Adapter implementation
     //
@@ -173,10 +167,12 @@ abstract class BitcoinBaseAdapter(
 
     override fun start() {
         kit.start()
+        subscribeToEvents()
     }
 
     override fun stop() {
         kit.stop()
+        scope.cancel()
     }
 
     override fun refresh() {
@@ -215,6 +211,24 @@ abstract class BitcoinBaseAdapter(
         }
     }
 
+    private fun subscribeToEvents() {
+        scope.launch {
+            backgroundManager.stateFlow.collect { state ->
+                when (state) {
+                    BackgroundManagerState.EnterForeground -> {
+                        kit.onEnterForeground()
+                    }
+                    BackgroundManagerState.EnterBackground -> {
+                        kit.onEnterBackground()
+                    }
+                    BackgroundManagerState.AllActivitiesDestroyed -> {
+
+                    }
+                }
+            }
+        }
+    }
+
     override fun getRawTransaction(transactionHash: String): String? {
         return kit.getRawTransaction(transactionHash)
     }

app/src/main/java/io/horizontalsystems/bankwallet/core/managers/BalanceHiddenManager.kt

@@ -2,14 +2,19 @@ package io.horizontalsystems.bankwallet.core.managers
 
 import io.horizontalsystems.bankwallet.core.ILocalStorage
 import io.horizontalsystems.core.BackgroundManager
+import io.horizontalsystems.core.BackgroundManagerState
+import kotlinx.coroutines.CoroutineScope
+import kotlinx.coroutines.Dispatchers
+import kotlinx.coroutines.SupervisorJob
 import kotlinx.coroutines.flow.MutableStateFlow
 import kotlinx.coroutines.flow.asStateFlow
 import kotlinx.coroutines.flow.update
+import kotlinx.coroutines.launch
 
 class BalanceHiddenManager(
     private val localStorage: ILocalStorage,
     backgroundManager: BackgroundManager,
-): BackgroundManager.Listener {
+) {
     val balanceHidden: Boolean
         get() = localStorage.balanceHidden
 
@@ -20,9 +25,16 @@ class BalanceHiddenManager(
 
     private val _balanceHiddenFlow = MutableStateFlow(localStorage.balanceHidden)
     val balanceHiddenFlow = _balanceHiddenFlow.asStateFlow()
+    private val scope = CoroutineScope(SupervisorJob() + Dispatchers.IO)
 
     init {
-        backgroundManager.registerListener(this)
+        scope.launch {
+            backgroundManager.stateFlow.collect { state ->
+                if (state == BackgroundManagerState.EnterBackground && balanceAutoHide) {
+                    setBalanceHidden(true)
+                }
+            }
+        }
 
         if (balanceAutoHide) {
             setBalanceHidden(true)
@@ -42,12 +54,6 @@ class BalanceHiddenManager(
         }
     }
 
-    override fun didEnterBackground() {
-        if (balanceAutoHide) {
-            setBalanceHidden(true)
-        }
-    }
-
     private fun setBalanceHidden(hidden: Boolean) {
         localStorage.balanceHidden = hidden
         _balanceHiddenFlow.update { localStorage.balanceHidden }

app/src/main/java/io/horizontalsystems/bankwallet/core/managers/ConnectivityManager.kt

@@ -7,18 +7,23 @@ import android.net.NetworkCapabilities
 import android.net.NetworkRequest
 import io.horizontalsystems.bankwallet.core.App
 import io.horizontalsystems.core.BackgroundManager
+import io.horizontalsystems.core.BackgroundManagerState
 import io.reactivex.subjects.PublishSubject
+import kotlinx.coroutines.CoroutineScope
+import kotlinx.coroutines.Dispatchers
+import kotlinx.coroutines.SupervisorJob
 import kotlinx.coroutines.channels.BufferOverflow
 import kotlinx.coroutines.flow.MutableSharedFlow
 import kotlinx.coroutines.flow.asSharedFlow
+import kotlinx.coroutines.launch
 
 
-class ConnectivityManager(backgroundManager: BackgroundManager) : BackgroundManager.Listener {
+class ConnectivityManager(backgroundManager: BackgroundManager) {
 
     private val connectivityManager: ConnectivityManager by lazy {
         App.instance.getSystemService(Context.CONNECTIVITY_SERVICE) as ConnectivityManager
     }
-
+    private val scope = CoroutineScope(SupervisorJob() + Dispatchers.IO)
     private val _networkAvailabilityFlow =
         MutableSharedFlow<Boolean>(extraBufferCapacity = 1, onBufferOverflow = BufferOverflow.DROP_OLDEST)
 
@@ -32,11 +37,24 @@ class ConnectivityManager(backgroundManager: BackgroundManager) : BackgroundMana
     private var hasConnection = false
 
     init {
-        backgroundManager.registerListener(this)
+        scope.launch {
+            backgroundManager.stateFlow.collect { state ->
+                when (state) {
+                    BackgroundManagerState.EnterForeground -> {
+                        willEnterForeground()
+                    }
+                    BackgroundManagerState.EnterBackground -> {
+                        didEnterBackground()
+                    }
+                    BackgroundManagerState.AllActivitiesDestroyed -> {
+                        //do nothing
+                    }
+                }
+            }
+        }
     }
 
-    override fun willEnterForeground() {
-        super.willEnterForeground()
+    private fun willEnterForeground() {
         setInitialValues()
         try {
             connectivityManager.unregisterNetworkCallback(callback)
@@ -46,8 +64,7 @@ class ConnectivityManager(backgroundManager: BackgroundManager) : BackgroundMana
         connectivityManager.registerNetworkCallback(NetworkRequest.Builder().build(), callback)
     }
 
-    override fun didEnterBackground() {
-        super.didEnterBackground()
+    private fun didEnterBackground() {
         try {
             connectivityManager.unregisterNetworkCallback(callback)
         } catch (e: Exception) {

app/src/main/java/io/horizontalsystems/bankwallet/core/managers/EvmKitManager.kt

@@ -8,6 +8,7 @@ import io.horizontalsystems.bankwallet.core.supportedNftTypes
 import io.horizontalsystems.bankwallet.entities.Account
 import io.horizontalsystems.bankwallet.entities.AccountType
 import io.horizontalsystems.core.BackgroundManager
+import io.horizontalsystems.core.BackgroundManagerState
 import io.horizontalsystems.erc20kit.core.Erc20Kit
 import io.horizontalsystems.ethereumkit.core.EthereumKit
 import io.horizontalsystems.ethereumkit.core.signer.Signer
@@ -30,20 +31,20 @@ import io.reactivex.subjects.BehaviorSubject
 import io.reactivex.subjects.PublishSubject
 import kotlinx.coroutines.CoroutineScope
 import kotlinx.coroutines.Dispatchers
+import kotlinx.coroutines.Job
 import kotlinx.coroutines.launch
 import kotlinx.coroutines.rx2.asFlow
 import java.net.URI
 
 class EvmKitManager(
     val chain: Chain,
-    backgroundManager: BackgroundManager,
+    private val backgroundManager: BackgroundManager,
     private val syncSourceManager: EvmSyncSourceManager
-) : BackgroundManager.Listener {
+) {
     private val coroutineScope = CoroutineScope(Dispatchers.Default)
+    private var job: Job? = null
 
     init {
-        backgroundManager.registerListener(this)
-
         coroutineScope.launch {
             syncSourceManager.syncSourceObservable.asFlow().collect { blockchain ->
                 handleUpdateNetwork(blockchain)
@@ -91,6 +92,7 @@ class EvmKitManager(
             evmKitWrapper = createKitInstance(accountType, account, blockchainType)
             useCount = 0
             currentAccount = account
+            subscribeToEvents()
         }
 
         useCount++
@@ -178,25 +180,26 @@ class EvmKitManager(
         }
     }
 
+    private fun subscribeToEvents(){
+        job = coroutineScope.launch {
+            backgroundManager.stateFlow.collect { state ->
+                if (state == BackgroundManagerState.EnterForeground) {
+                    evmKitWrapper?.evmKit?.let { kit ->
+                        Handler(Looper.getMainLooper()).postDelayed({
+                            kit.refresh()
+                        }, 1000)
+                    }
+                }
+            }
+        }
+    }
+
     private fun stopEvmKit() {
+        job?.cancel()
         evmKitWrapper?.evmKit?.stop()
         evmKitWrapper = null
         currentAccount = null
     }
-
-    //
-    // BackgroundManager.Listener
-    //
-
-    override fun willEnterForeground() {
-        this.evmKitWrapper?.evmKit?.let { kit ->
-            Handler(Looper.getMainLooper()).postDelayed({
-                kit.refresh()
-            }, 1000)
-        }
-    }
-
-    override fun didEnterBackground() = Unit
 }
 
 val RpcSource.uris: List<URI>