Mark as spam when incoming transaction has 0 coin value

horizontalsystems · Apr 9, 2024 · 7006697 · 7006697
1 parent b9fbf86
commit 7006697
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 2 deletions.
diff --git a/app/src/main/java/io/horizontalsystems/bankwallet/core/adapters/EvmTransactionConverter.kt b/app/src/main/java/io/horizontalsystems/bankwallet/core/adapters/EvmTransactionConverter.kt
@@ -66,7 +66,7 @@ class EvmTransactionConverter(
             }
 
             is IncomingDecoration -> {
-                EvmIncomingTransactionRecord(transaction, baseToken, source, decoration.from.eip55, baseCoinValue(decoration.value, false))
+                EvmIncomingTransactionRecord(transaction, baseToken, source, spamManager, decoration.from.eip55, baseCoinValue(decoration.value, false))
             }
 
             is OutgoingDecoration -> {

diff --git a/app/src/main/java/io/horizontalsystems/bankwallet/core/managers/SpamManager.kt b/app/src/main/java/io/horizontalsystems/bankwallet/core/managers/SpamManager.kt
@@ -44,6 +44,13 @@ class SpamManager(
         }
     }
 
+    fun isIncomingSpam(transactionValue: TransactionValue): Boolean {
+        return when(transactionValue) {
+            is TransactionValue.CoinValue -> transactionValue.value <= BigDecimal.ZERO
+            else -> false
+        }
+    }
+
     fun updateFilterHideSuspiciousTx(hide: Boolean) {
         localStorage.hideSuspiciousTransactions = hide
         hideSuspiciousTx = hide

diff --git a/...izontalsystems/bankwallet/entities/transactionrecords/evm/EvmIncomingTransactionRecord.kt b/...izontalsystems/bankwallet/entities/transactionrecords/evm/EvmIncomingTransactionRecord.kt
@@ -1,5 +1,6 @@
 package io.horizontalsystems.bankwallet.entities.transactionrecords.evm
 
+import io.horizontalsystems.bankwallet.core.managers.SpamManager
 import io.horizontalsystems.bankwallet.entities.TransactionValue
 import io.horizontalsystems.bankwallet.modules.transactions.TransactionSource
 import io.horizontalsystems.ethereumkit.models.Transaction
@@ -9,9 +10,16 @@ class EvmIncomingTransactionRecord(
     transaction: Transaction,
     baseToken: Token,
     source: TransactionSource,
+    spamManager: SpamManager,
     val from: String,
     val value: TransactionValue
-) : EvmTransactionRecord(transaction, baseToken, source, true) {
+) : EvmTransactionRecord(
+    transaction = transaction,
+    baseToken = baseToken,
+    source = source,
+    foreignTransaction = true,
+    spam = spamManager.isIncomingSpam(value)
+) {
 
     override val mainValue = value