Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GRPC + Rest endpoint to retreive VM Config, Inject and Inherit Secrets and Configmaps to environment config #204

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jggoebel
Copy link
Member

@jggoebel jggoebel commented Jul 23, 2024

What this PR does / why we need it:
Retreives the current VM Configuration for a given VM via a gRPC endpoint.
Needed by controllers, currently the terraform controller calculates the config themselves

VM Controller injects secret in fields where the value is
inject_secret:<name>:<field>
The same is applied for configmaps:
inject_configmap:<name>:<field>
This ensures that no secrets are stored directly inside the environment enabling us to store environments inside a git repository.

Also whole secrets and configmap data can be inherited by using
inherit_secrets as the key and a comma sepperated list with secret metadata.names
Same applies to inherit_configmaps for configmaps
Example
inherit_secrets = secret1,secret2 will inherit data from secret1 and secret2. So if secret1 has a field token with the value abc it will be added to the config

Also adds a REST endpoint in order to retreive VM configuration inside the admin ui in order to debug VMs

Before this PR the controller itself retreives the environment and checks if the given VMT is enabled on the environment.
This PR moves this behaviour to the VM creation, so that controllers do not have to check if this is a valid configuration.

Which issue(s) this PR fixes:

@jggoebel jggoebel changed the title Add GRPC + Rest endpoint to retreive VM Config Add GRPC + Rest endpoint to retreive VM Config, Inject and Inherit Secrets and Configmaps to environment config Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant