WIP: PasswordResetTokens #179
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jggoebel
changed the title
jggoebel
changed the title
jggoebel
changed the title
PhilipAB
reviewed
Feb 6, 2024
| @@ -90,19 +91,43 @@ func (c *DistributedController) getReplicaPlacement(obj interface{}) (int, error | |||
| } | |||
|
|
|||
| // RunDistributed will start a distributed controller concept | |||
There was a problem hiding this comment.
Suggested change
| // RunDistributed will start a distributed controller concept | |
| // RunSharded will start a sharded controller concept |
jggoebel
changed the title
Merged
jggoebel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR is a proposal for leader election in microservices when controllers are needed.
In this PR i create a PasswordResetToken controller (That is supposed to delete Password Reset Tokens after a given time - it is not yet finally implemented and i worked more on leader election)
Which issue(s) this PR fixes:
Leader Election inside a microservice world