Shared / Global VirtualMachines for ScheduledEvents #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jggoebel
changed the title
jggoebel
reviewed
Jul 14, 2023
pkg/vmserver/vmserver.go
Outdated
| return | ||
| } | ||
|
|
||
| accessCodeResource, err := vms.acClient.GetAccessCode(accessCode) |
There was a problem hiding this comment.
After merging master refactor this to acClient.GetAccessCodeWithOTAC as we changed the acClient to allow OTACs
jggoebel
reviewed
Jul 14, 2023
pkg/vmserver/vmserver.go
Outdated
| @@ -225,7 +284,7 @@ func (vms VMServer) GetVMListByScheduledEventFunc(w http.ResponseWriter, r *http | |||
| util.ReturnHTTPMessage(w, r, 500, "error", "no scheduledEvent id passed in") | |||
| return | |||
| } | |||
|
|
|||
| // TODO: Filter for sharedVM | |||
|
I would prefer not to merge this until we have a clear picture of what the new machine provisioning will look like. This PR is going to need adjustments based on that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
add Shared Virtual Machine to ScheduledEvent
Which issue(s) this PR fixes:
fixes issue 166