Verification checks against VM (Tasks for the user) #149
Conversation
| @@ -697,6 +698,18 @@ func (s ScenarioServer) CreateFunc(w http.ResponseWriter, r *http.Request) { | |||
| scenario.Spec.Tags = tags | |||
| scenario.Spec.KeepAliveDuration = keepaliveDuration | |||
|
|
|||
| rawVMTasks := r.PostFormValue("vm_tasks") | |||
| if rawVMTasks != "" { | |||
There was a problem hiding this comment.
in the Update Metod you validate the Input, here you do not validate the input. Better to build a function to valdiate VirtualMachineTasks and use it in both methods
jggoebel
changed the title
|
Please hold off on merging this until we sort out the machine prov stuff |
|
@ebauman This PR changes nothing for VM provisioning. It only touches scenarios + shell server. But we could still hold this |
|
it's mostly a naming thing, i'd like to move away from "virtualmachine" and towards "machine". if we're going to issue a scenario v2 it should have those changes. |
|
We might need to update how a task is viewed as successful. We should make it optional to use both methods, one of the methods alone should be also ok. |
|
Closed in favor of #180 |
*Task193 / The ability to verifiy different things on VMs:
add tasks(commands) to scenario
Task193 / Run multiple commands on VMs:
run VM in go routine, run commands in limited count(with Semaphore) of go routine
fixes hobbyfarm/hobbyfarm#193