Skip to content

Commit

Permalink
(fix): getTileData args changed (#632)
Browse files Browse the repository at this point in the history
* (fix): `getTileData` args changed

* (lint): remove console.log

* (chore): changelog.
  • Loading branch information
ilan-gold committed Aug 25, 2022
1 parent 4779f89 commit 26e67bf
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,20 @@
### Added

### Changed

- Upgrade deck.gl to 8.8
- Use correct deck.gl 8.8 `getTileData` args.
- Replace `postversion` script with `version` script for CI release.
- Remove `package-lock.json` from root (since we use pnpm)

## 0.13.1

### Added

- Added support for loading multiple single channel TIFFs.

### Changed

- Update doc strings for `loadMultiTiff`
- Update release notes in `README.md`

Expand All @@ -23,6 +27,7 @@
### Added

### Changed

- Migrate to pnpm monorepo
- Fix all image URLs in README
- Only run CHANGELOG action on pull_requests
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,12 +66,11 @@ const MultiscaleImageLayer = class extends CompositeLayer {
} = this.props;
// Get properties from highest resolution
const { tileSize, dtype } = loader[0];

// This is basically to invert:
// https://github.com/visgl/deck.gl/pull/4616/files#diff-4d6a2e500c0e79e12e562c4f1217dc80R128
// The z level can be wrong for showing the correct scales because of the calculation deck.gl does
// so we need to invert it for fetching tiles and minZoom/maxZoom.
const getTileData = async ({ x, y, z, signal }) => {
const getTileData = async ({ index: { x, y, z }, signal }) => {
// Early return if no selections
if (!selections || selections.length === 0) {
return null;
Expand Down

0 comments on commit 26e67bf

Please sign in to comment.