[ALS-6235] Investigate: BDC Auth login issue: Explore delays creating…

… the user roles (#173)

[ALS-6235] Investigate: BDC Auth login issue: Explore delays creating the user roles

FenceAuthorization service has been refactored to improve readability and modularity.
Fence mapping utility now loads the fence mapping json data on application startup and initializes two maps used by the application. This reduced execution time from ~13.25 minutes to ~9 minutes.
AccessRules now uses a cache when creating new AccessRules. This reduces the time spent querying the database as many access rules are reused by privileges. This change reduced execution time from ~9 minutes down to 2.25 - 2.5 minutes.
Refactor Role creation to allow for parallelization. This reduced execution time from 2.25 - 2.5 minutes down to ~30seconds.
Roles are no longer removed from the user on login. We now update the user roles in place.

pic-sure-auth-services/src/main/java/edu/harvard/hms/dbmi/avillach/auth/data/repository/RoleRepository.java

@@ -5,6 +5,7 @@
 
 import javax.enterprise.context.ApplicationScoped;
 import javax.transaction.Transactional;
+import java.util.List;
 import java.util.UUID;
 
 /**
@@ -18,4 +19,14 @@ public class RoleRepository extends BaseRepository<Role, UUID> {
     protected RoleRepository() {
         super(Role.class);
     }
+
+    public void persistAll(List<Role> newRoles) {
+        for (Role newRole : newRoles) {
+            if (newRole.getUuid() == null) {
+                em.persist(newRole);
+            } else {
+                em.merge(newRole);
+            }
+        }
+    }
 }

pic-sure-auth-services/src/main/java/edu/harvard/hms/dbmi/avillach/auth/rest/StudyAccessService.java

@@ -3,6 +3,7 @@
 import edu.harvard.hms.dbmi.avillach.auth.data.entity.Role;
 import edu.harvard.hms.dbmi.avillach.auth.data.repository.RoleRepository;
 import edu.harvard.hms.dbmi.avillach.auth.service.auth.FENCEAuthenticationService;
+import edu.harvard.hms.dbmi.avillach.auth.utils.FenceMappingUtility;
 import io.swagger.annotations.Api;
 import io.swagger.annotations.ApiOperation;
 import io.swagger.annotations.ApiParam;
@@ -37,6 +38,9 @@ public class StudyAccessService {
     public static final String STUDY_IDENTIFIER = "study_identifier";
     public static final String CONSENT_GROUP_CODE = "consent_group_code";
 
+    @Inject
+    private FenceMappingUtility fenceUtilityMapping;
+
     @Inject
     FENCEAuthenticationService fenceAuthenticationService;
 
@@ -55,7 +59,7 @@ public Response addStudyAccess(@ApiParam(value="The Study Identifier of the new
         Map fenceMappingForStudy = null;
 
         try {
-            Map<String, Map> fenceMapping = fenceAuthenticationService.getFENCEMapping();
+            Map<String, Map> fenceMapping = this.fenceUtilityMapping.getFENCEMapping();
             if (fenceMapping == null) {
                 throw new Exception("Fence mapping is null");
             }