Optimize privilege accumulation with parallel streams

Performance has been improved for privilege accumulation in the User entity. This was achieved by replacing standard forEach loops with parallelStreams, increasing efficiency particularly with large sets of user roles and privileges.
hms-dbmi · Jul 8, 2024 · 0179725 · 0179725
1 parent c2d927c
commit 0179725
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/pic-sure-auth-services/src/main/java/edu/harvard/hms/dbmi/avillach/auth/entity/User.java b/pic-sure-auth-services/src/main/java/edu/harvard/hms/dbmi/avillach/auth/entity/User.java
@@ -106,7 +106,7 @@ public Set<Privilege> getTotalPrivilege(){
 			return null;
 
 		Set<Privilege> privileges = new HashSet<>();
-		roles.forEach(r -> privileges.addAll(r.getPrivileges()));
+		roles.parallelStream().forEach(r -> privileges.addAll(r.getPrivileges()));
 		return privileges;
 	}
 
@@ -181,7 +181,7 @@ public Set<Privilege> getPrivilegesByApplication(Application application){
 			return null;
 
 		Set<Privilege> privileges = new HashSet<>();
-		roles.forEach(r -> privileges.addAll(r.getPrivileges()
+		roles.parallelStream().forEach(r -> privileges.addAll(r.getPrivileges()
 						.stream()
 						.filter(p -> application.getUuid()
                                 .equals((p.getApplication()==null)?