Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readxyz #266

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Readxyz #266

wants to merge 5 commits into from

Conversation

jwtoney
Copy link
Contributor

@jwtoney jwtoney commented Sep 13, 2024

update readfromxyz to allow xyz files as strings

Copy link
Contributor

@gianmarco-terrones gianmarco-terrones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as you only changed the test cases that were absolutely necessary to change due to the change in oct default value in getBondedAtomsOct, this should be good

Copy link
Contributor

@aarongarrison aarongarrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the test case changes are the same as in commit 0ed95c5. The changes to the readfromxyz function look good to me.

s = filename.split('\n')
try:
s.remove('')
except ValueError:

Check notice

Code scanning / CodeQL

Empty except Note

'except' clause does nothing but pass and there is no explanatory comment.
Copy link

codecov bot commented Sep 14, 2024

Codecov Report

Attention: Patch coverage is 38.09524% with 26 lines in your changes missing coverage. Please review.

Project coverage is 37.38%. Comparing base (e9b1d7b) to head (a298bca).

Files with missing lines Patch % Lines
molSimplify/Classes/mol3D.py 38.09% 26 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #266      +/-   ##
==========================================
- Coverage   37.40%   37.38%   -0.03%     
==========================================
  Files          89       89              
  Lines       29827    29846      +19     
==========================================
+ Hits        11158    11159       +1     
- Misses      18669    18687      +18     
Flag Coverage Δ
unittests 37.38% <38.09%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants