-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(26237): Refactor the request infrastructure to the OpenAPI specs #566
Draft
vanch3d
wants to merge
19
commits into
epic/23777/bi-directional-frontend
Choose a base branch
from
refactor/26237/update-openapi-bi-direct
base: epic/23777/bi-directional-frontend
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
refactor(26237): Refactor the request infrastructure to the OpenAPI specs #566
vanch3d
wants to merge
19
commits into
epic/23777/bi-directional-frontend
from
refactor/26237/update-openapi-bi-direct
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roperly handle mocks
- update mocks - update tests
…E being in the specs
- rename GET hook
- remove old hooks - update mocks
…QTT dev Client - relocate the provider - export the sampling routine to handlers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://hivemq.kanbanize.com/ctrl_board/57/cards/26237/details/
This PR is part of the bi-directional epic and refactors the query infrastructure to abide to the OpenAPI specs proposed in #563
Design
The current implementation of the bi-directional features in the frontend is still based on a series of mocks (both data and process) to bypass the work-in-progress nature of the backend.
To drive the alignment of the two parts of the engineering process, a proposal was made for the expected API endpoints.
The PR refactors the bespoke mocks into a proper micro-service API mocking
React Query
hooksMSW
to intercept the requests and populate the returned bodydev
-only and integrated with the relevantMSW
handlersNote that
MSW
needs to be activated for the mocks to be introduced. Change the following environment variable in theenv.local
files: