Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Realworld Biome usage example #245

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Realworld Biome usage example #245

wants to merge 5 commits into from

Conversation

antpaw
Copy link
Contributor

@antpaw antpaw commented Dec 15, 2023

Motivation

This is just a real world example of using Biome in a ESLint/Prettier project. I don't need this to be merged.

Changes

Most of the changes this has caused are:

  • Trailing commas, I think this a great addition, it saves typing whenever adding a new key and it reduces changed lines of code to review in a PR.
  • Resorting imports, I'm neutral about this one, but to me the Biome way of sorting makes slightly more sens

Here are my comments on each of the commits:

  • In the first commit f8da73b install and format of code
  • a743ea6 autofix lint
  • fae2c69 manually fixed issues that are not auto fixable and (hopefully) trivial
  • e5d7812 this a complex change, the docs have convinced me that this is necessary
  • dbebe5a the docs have convinced me that this is necessary

@cla-bot cla-bot bot added the cla-signed label Dec 15, 2023
@sfrehse
Copy link
Contributor

sfrehse commented Feb 9, 2024

@antpaw Is this PR still required? What is expected here?

@antpaw
Copy link
Contributor Author

antpaw commented Feb 9, 2024

@sfrehse this is an example for an upcoming RFD about js/ts formating and linting. May we keep this around for another month or two? There is a high chance that Biome gets selected and it would be great if a version of this pr would be merged to Edge.

@sfrehse
Copy link
Contributor

sfrehse commented Feb 9, 2024

@sfrehse this is an example for an upcoming RFD about js/ts formating and linting. May we keep this around for another month or two? There is a high chance that Biome gets selected and it would be great if a version of this pr would be merged to Edge.

Ok, fine for me! 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants