Skip to content
This repository has been archived by the owner on Jan 2, 2023. It is now read-only.

Update coreteam.css #325

Merged
merged 1 commit into from
May 31, 2021
Merged

Conversation

s-s5678
Copy link
Contributor

@s-s5678 s-s5678 commented May 29, 2021

Changes in Font and Font-styles

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue no.)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Explain the Testing instructions

Test Configuration:

  • Operating system:
  • Version:
  • Text-editors used:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

ATTACH SCREEN-SHOTS

Changes in Font and Font-styles
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉Congratulations!!🎉 for making your first PR , our mentors will review it soon.

@himanshu007-creator
Copy link
Owner

@s-s5678 Please host your branch on github and share the link

@rohan-kulkarni-25
Copy link
Contributor

Please also link on which issue you was working !

@s-s5678
Copy link
Contributor Author

s-s5678 commented May 29, 2021

@s-s5678 Please host your branch on github and share the link

https://s-s5678.github.io/SFC-foundations/pages/About-Us/coreteam.html

@rohan-kulkarni-25
Copy link
Contributor

Please make it lighter 300 or 400 might look more better @himanshu007-creator What you think ?

@s-s5678
Copy link
Contributor Author

s-s5678 commented May 29, 2021

Please make it lighter 300 or 400 might look more better @himanshu007-creator What you think ?

issue #5

@rohan-kulkarni-25
Copy link
Contributor

Please make it lighter 300 or 400 might look more better @himanshu007-creator What you think ?

issue #5

No this is not related to that ?

@rohan-kulkarni-25
Copy link
Contributor

Please make it lighter 300 or 400 might look more better @himanshu007-creator What you think ?

issue #5

It's ok that you make changes but these are changes we can accept if you might have done something we don't accept or don't like then this will waste your efforts so it is advised to create issue and work on that !! Just take it as suggestion @s-s5678

@s-s5678
Copy link
Contributor Author

s-s5678 commented May 29, 2021

Please make it lighter 300 or 400 might look more better @himanshu007-creator What you think ?

issue #5

It's ok that you make changes but these are changes we can accept if you might have done something we don't accept or don't like then this will waste your efforts so it is advised to create issue and work on that !! Just take it as suggestion @s-s5678

Okay sir!

@himanshu007-creator
Copy link
Owner

@s-s5678 you can work on the team chandigarh button. It should be in single line, what you can do is reduce size of all teh buttons and bold them, what do you say @rohank2502 ?

@rohan-kulkarni-25
Copy link
Contributor

can work on the team chandigarh butt

Can you please attach ss @himanshu007-creator Because I am not getting where it is in 2 line

@rohan-kulkarni-25
Copy link
Contributor

Please make it lighter 300 or 400 might look more better @himanshu007-creator What you think ?

issue #5

It's ok that you make changes but these are changes we can accept if you might have done something we don't accept or don't like then this will waste your efforts so it is advised to create issue and work on that !! Just take it as suggestion @s-s5678

Okay sir!

You can say Rohan

@himanshu007-creator himanshu007-creator linked an issue May 29, 2021 that may be closed by this pull request
@himanshu007-creator himanshu007-creator added gssoc21 Issues part of gssoc'21 Level1 labels May 29, 2021
@github-actions
Copy link

Thank you @s-s5678 for the PR. Our mentors will review it soon. This issue counts towards the GSSOC'21

@himanshu007-creator himanshu007-creator merged commit f33a5da into himanshu007-creator:master May 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
gssoc21 Issues part of gssoc'21
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants