Fix: 377 Allow commas in urls on data-srcset #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I found an error with it, I'm fixing it right now |
|
👍 |
hsxfjames
reviewed
Nov 4, 2019
| @@ -66,12 +66,13 @@ function getBestSelectionFromSrcset (el, scale) { | |||
| const result = [] | |||
| const container = el.parentNode | |||
| const containerWidth = container.offsetWidth * scale | |||
| const splitArg = options.includes(',\n') ? ',\n' : ', ' | |||
There was a problem hiding this comment.
I tried with /,\s+/ and ain't working. With the ,\n works fine.
There was a problem hiding this comment.
Why the /,\s+/ does not work? /,\n/ is not very suitable.
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding #377
The previous code trimmed al the spaces and uses the commas to split, but urls can containn comas.
For example, Cloudinary (pretty use in the FE side) uses commas in their transformation paths like this:
https://res.cloudinary.com/alvarosaburido/image/upload/c_scale,q_auto,w_320/v1563876252/alvaro-saburido-portfolio.pngThis solution will split a common srcset. The trimming is also done after it for each item so no problem about white spaces.