Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

theme: add acrylic #2034

Closed
wants to merge 4 commits into from
Closed

theme: add acrylic #2034

wants to merge 4 commits into from

Conversation

Ezgx
Copy link
Contributor

@Ezgx Ezgx commented Jul 19, 2023

Check List

Please read and check followings before submitting a PR.

  • I want to publish my theme on Hexo official website.
    • I have read the theme publishing doc.
    • name is unique.
    • link URL is correct.
    • preview URL is correct.
    • preview URL web site is rendered correctly.
    • Add a screenshot to source/themes/screenshots.
    • Screenshot filename is same as value of name.
    • Screenshot size is 800 * 500.
    • Screenshot file format is png.
  • I want to publish my plugin on Hexo official website.
  • Others (Update, fix, translation, etc...)
    • Languages:
    • en English
    • ru Russian
    • zh-cn simplified Chinese
    • zh-tw traditional Chinese

Note

No need to translate ko, pt-br, th languages if you submit a PR for documentation.

Warning

ko, pt-br, th languages document are inactive. Please, submit issue if you want to continuous contribution to them.

@uiolee uiolee changed the title add theme acrylic theme: add acrylic Sep 2, 2023
uiolee
uiolee requested changes Oct 19, 2023
View reviewed changes
Copy link
Member

@uiolee uiolee left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow theme publishing doc to publish theme.

And I think you'd better split this PR into two or three PRs.

source/_data/themes.yml
@@ -4047,7 +4058,7 @@
- name: dimension
description: 一个二次元风格设计的hexo主题
link: https://github.com/ezgx/hexo-theme-dimension
preview: http://demo.dimension.ezgx.site/
preview: http://demo.dim.sssu.us
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This site can’t be reached

source/_data/themes.yml
@@ -1,13 +1,24 @@
- name: Acrylic-next
description: A minimalist but not simple theme, designed by Heo.
link: https://github.com/hexo-theme-Acrylic/Hexo-Theme-Acrylic-Next
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repository has been archived by the owner on Sep 15, 2023. It is now read-only.

@uiolee uiolee marked this pull request as draft October 19, 2023 15:12
@uiolee uiolee added the Themes _data/themes/ label Oct 23, 2023
@stevenjoezhang
Copy link
Member

I will close this pull request because it seems that this theme has already been discontinued. Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uiolee uiolee uiolee requested changes

Assignees
No one assigned
Labels
need-update Themes _data/themes/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ezgx @stevenjoezhang @uiolee