feat(exp): add sliceutil package #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jooola
commented
Jul 19, 2024
jooola
commented
- Adds a Batches utility to split slices into batches.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #489 +/- ##
==========================================
+ Coverage 71.54% 71.57% +0.02%
==========================================
Files 45 46 +1
Lines 3901 3905 +4
==========================================
+ Hits 2791 2795 +4
Misses 696 696
Partials 414 414 ☔ View full report in Codecov by Sentry. |
apricote
approved these changes
Jul 22, 2024
|
Opps. I went on a journey, and it looks like this functionality is already merged in Go stdlib and will be released with 1.23: https://go-review.googlesource.com/c/go/+/562935 |
|
Nice, we will be to replace this utility with the std lib once we dropped go 1.22 |
jooola
pushed a commit
that referenced
this pull request
Jul 23, 2024
🤖 I have created a release *beep* *boop* --- ## [2.11.0](v2.10.2...v2.11.0) (2024-07-23) ### Features * add truncated exponential backoff with full jitter ([#459](#459)) ([fd1f46c](fd1f46c)) * allow configuring retry options ([#488](#488)) ([2db9575](2db9575)) * **exp:** add sliceutil package ([#489](#489)) ([f4ad6bc](f4ad6bc)) * **exp:** rename `*utils` package to `*util` ([#487](#487)) ([19da475](19da475)) * respect cancelled contexts during retry sleep ([#470](#470)) ([756f605](756f605)) * retry requests when the api gateway errors ([#470](#470)) ([756f605](756f605)) * retry requests when the network timed out ([#470](#470)) ([756f605](756f605)) * retry requests when the rate limit was reached ([#470](#470)) ([756f605](756f605)) ### Bug Fixes * **exp:** set capacity for each batch ([#490](#490)) ([57f53c1](57f53c1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
apricote
pushed a commit
to hetznercloud/fleeting-plugin-hetzner
that referenced
this pull request
Sep 12, 2024
…1.0 (hetznercloud/fleeting-plugin-hetzner!98) This MR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/hetznercloud/hcloud-go/v2](https://github.com/hetznercloud/hcloud-go) | require | minor | `v2.10.2` -> `v2.11.0` | --- ### Release Notes <details> <summary>hetznercloud/hcloud-go (github.com/hetznercloud/hcloud-go/v2)</summary> ### [`v2.11.0`](https://github.com/hetznercloud/hcloud-go/releases/tag/v2.11.0) [Compare Source](hetznercloud/hcloud-go@v2.10.2...v2.11.0) ##### Features - add truncated exponential backoff with full jitter ([#​459](hetznercloud/hcloud-go#459)) ([fd1f46c](hetznercloud/hcloud-go@fd1f46c)) - allow configuring retry options ([#​488](hetznercloud/hcloud-go#488)) ([2db9575](hetznercloud/hcloud-go@2db9575)) - **exp:** add sliceutil package ([#​489](hetznercloud/hcloud-go#489)) ([f4ad6bc](hetznercloud/hcloud-go@f4ad6bc)) - **exp:** rename `*utils` package to `*util` ([#​487](hetznercloud/hcloud-go#487)) ([19da475](hetznercloud/hcloud-go@19da475)) - respect cancelled contexts during retry sleep ([#​470](hetznercloud/hcloud-go#470)) ([756f605](hetznercloud/hcloud-go@756f605)) - retry requests when the api gateway errors ([#​470](hetznercloud/hcloud-go#470)) ([756f605](hetznercloud/hcloud-go@756f605)) - retry requests when the network timed out ([#​470](hetznercloud/hcloud-go#470)) ([756f605](hetznercloud/hcloud-go@756f605)) - retry requests when the rate limit was reached ([#​470](hetznercloud/hcloud-go#470)) ([756f605](hetznercloud/hcloud-go@756f605)) ##### Bug Fixes - **exp:** set capacity for each batch ([#​490](hetznercloud/hcloud-go#490)) ([57f53c1](hetznercloud/hcloud-go@57f53c1)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.