Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow configuring retry options #488

Merged
merged 1 commit into from
Jul 22, 2024
Merged

feat: allow configuring retry options #488

merged 1 commit into from
Jul 22, 2024

Conversation

jooola
Copy link
Member

@jooola jooola commented Jul 18, 2024

This lets the user configure the retry options, with a custom back off function and the max number of retries.

@jooola jooola requested a review from a team as a code owner July 18, 2024 10:06
@jooola jooola requested a review from apricote July 18, 2024 10:06
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.51%. Comparing base (f7ac563) to head (9e66f22).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #488      +/-   ##
==========================================
- Coverage   71.56%   71.51%   -0.05%     
==========================================
  Files          45       45              
  Lines        3903     3907       +4     
==========================================
+ Hits         2793     2794       +1     
- Misses        696      699       +3     
  Partials      414      414              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jooola jooola merged commit 2db9575 into main Jul 22, 2024
4 checks passed
@jooola jooola deleted the retry-opts branch July 22, 2024 13:33
jooola pushed a commit that referenced this pull request Jul 23, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.11.0](v2.10.2...v2.11.0)
(2024-07-23)


### Features

* add truncated exponential backoff with full jitter
([#459](#459))
([fd1f46c](fd1f46c))
* allow configuring retry options
([#488](#488))
([2db9575](2db9575))
* **exp:** add sliceutil package
([#489](#489))
([f4ad6bc](f4ad6bc))
* **exp:** rename `*utils` package to `*util`
([#487](#487))
([19da475](19da475))
* respect cancelled contexts during retry sleep
([#470](#470))
([756f605](756f605))
* retry requests when the api gateway errors
([#470](#470))
([756f605](756f605))
* retry requests when the network timed out
([#470](#470))
([756f605](756f605))
* retry requests when the rate limit was reached
([#470](#470))
([756f605](756f605))


### Bug Fixes

* **exp:** set capacity for each batch
([#490](#490))
([57f53c1](57f53c1))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
apricote pushed a commit to hetznercloud/fleeting-plugin-hetzner that referenced this pull request Sep 12, 2024
…1.0 (hetznercloud/fleeting-plugin-hetzner!98)

This MR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/hetznercloud/hcloud-go/v2](https://github.com/hetznercloud/hcloud-go) | require | minor | `v2.10.2` -> `v2.11.0` |

---

### Release Notes

<details>
<summary>hetznercloud/hcloud-go (github.com/hetznercloud/hcloud-go/v2)</summary>

### [`v2.11.0`](https://github.com/hetznercloud/hcloud-go/releases/tag/v2.11.0)

[Compare Source](hetznercloud/hcloud-go@v2.10.2...v2.11.0)

##### Features

-   add truncated exponential backoff with full jitter ([#&#8203;459](hetznercloud/hcloud-go#459)) ([fd1f46c](hetznercloud/hcloud-go@fd1f46c))
-   allow configuring retry options ([#&#8203;488](hetznercloud/hcloud-go#488)) ([2db9575](hetznercloud/hcloud-go@2db9575))
-   **exp:** add sliceutil package ([#&#8203;489](hetznercloud/hcloud-go#489)) ([f4ad6bc](hetznercloud/hcloud-go@f4ad6bc))
-   **exp:** rename `*utils` package to `*util` ([#&#8203;487](hetznercloud/hcloud-go#487)) ([19da475](hetznercloud/hcloud-go@19da475))
-   respect cancelled contexts during retry sleep ([#&#8203;470](hetznercloud/hcloud-go#470)) ([756f605](hetznercloud/hcloud-go@756f605))
-   retry requests when the api gateway errors ([#&#8203;470](hetznercloud/hcloud-go#470)) ([756f605](hetznercloud/hcloud-go@756f605))
-   retry requests when the network timed out ([#&#8203;470](hetznercloud/hcloud-go#470)) ([756f605](hetznercloud/hcloud-go@756f605))
-   retry requests when the rate limit was reached ([#&#8203;470](hetznercloud/hcloud-go#470)) ([756f605](hetznercloud/hcloud-go@756f605))

##### Bug Fixes

-   **exp:** set capacity for each batch ([#&#8203;490](hetznercloud/hcloud-go#490)) ([57f53c1](hetznercloud/hcloud-go@57f53c1))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants