chore: do not retry on bare HTTP 429 or HTTP 503 #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jooola
force-pushed
the
update-retry-policy
branch
from
daf72a3
to
c829019
Compare
Related to #470 We prefer not to retry requests: - If the ingress return a "bare" 429, as the backend was not able to respond anyway. - If the ingress return a "bare" 503, to prevent possible self made ddos, and preventing a disaster recovery.
jooola
force-pushed
the
update-retry-policy
branch
from
c829019
to
fbafb2e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #486 +/- ##
==========================================
- Coverage 71.56% 71.54% -0.02%
==========================================
Files 45 45
Lines 3903 3901 -2
==========================================
- Hits 2793 2791 -2
Misses 696 696
Partials 414 414 ☔ View full report in Codecov by Sentry. |
jooola
changed the title
apricote
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #470
This is only a
choreto prevent confusion with the now updated release-please commits in #470We prefer not to retry requests: