feat: add conversion methods from schema to hcloud objects #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phm07
force-pushed
the
goverter
branch
2 times, most recently
from
4fbf0f6
to
74c1bd4
Compare
phm07
force-pushed
the
goverter
branch
2 times, most recently
from
047a226
to
701f381
Compare
|
@jmattheis Feel free to leave some feedback here 🙂 Maybe something can be done better/more efficiently than how I did it |
jmattheis
reviewed
Dec 2, 2023
This was referenced Dec 5, 2023
phm07
changed the title
apricote
reviewed
Dec 7, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | golang.org/x/net | require | minor | `v0.18.0` -> `v0.19.0` | --- <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuODEuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
phm07
added a commit
that referenced
this pull request
Dec 12, 2023
phm07
pushed a commit
that referenced
this pull request
Dec 12, 2023
🤖 I have created a release *beep* *boop* --- ## [2.5.0](v2.4.0...v2.5.0) (2023-12-12) ### Features * add conversion methods from schema to hcloud objects ([#343](#343)) ([6feda4d](6feda4d)) * add interfaces for client structs ([#342](#342)) ([4f9390f](4f9390f)) * add missing properties ([#349](#349)) ([c8a28d0](c8a28d0)) * **error:** include http response in api errors ([#320](#320)) ([9558239](9558239)) ### Bug Fixes * make schemas consistent with API ([#348](#348)) ([b0d7055](b0d7055)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds automatic generation of schema conversion methods in
schema.gowith goverter.Previously,
schema.gowas manually written. This is a tedious task and is also prone to errors.This PR also adds new methods to convert
hcloudobjects back into schemas. This allows for round trip testing (convertingschema -> hcloud -> schemaorhcloud -> schema -> hcloudand testing for equality) and allows for removal of redundant code in hcloud/cli.Since the round trip tests ensure that a schema converts into an
hcloudobject and back, formatting will be consistent between conversions. This would fix issues like hetznercloud/cli#461.