Add toggle to change timezone to UTC for Nakama Console graphs #1260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toqueteos
force-pushed
the
console-add-utc-toggle
branch
from
a9b73ff
to
bf5de5f
Compare
toqueteos
commented
Aug 3, 2024
| @@ -13,7 +13,7 @@ | |||
| // limitations under the License. | |||
|
|
|||
| import {Component, OnInit, OnDestroy, Injectable, Pipe, PipeTransform} from '@angular/core'; | |||
| import {ConsoleService, StatusList, StatusListStatus} from '../console.service'; | |||
| import {ConsoleService, StatusList} from '../console.service'; | |||
There was a problem hiding this comment.
I removed StatusListStatus as it's unused in this file.
toqueteos
force-pushed
the
console-add-utc-toggle
branch
from
2e921f7
to
d029394
Compare
|
Rebased with latest master |
|
This LGTM but I'd kindly ask @jpntex to give it a second pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #703 /cc @mofirouz
I only see charts in the Status page.
Please do tell me if there charts in some other page and I'll update them too!
Demo:
2024-08-03.15-33-05.mp4