Improve nakama migrate errors #1258
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toqueteos
commented
Aug 2, 2024
| db.Close() | ||
| logger.Fatal("Failed to check if db exists", zap.String("db", dbName), zap.Error(err)) | ||
| } | ||
| nakamaDBExists = false |
There was a problem hiding this comment.
This line can be removed as the logger.Fatal will terminate the execution anyways
toqueteos
force-pushed
the
improve-nakama-migrate-errors
branch
from
a128078
to
6d3cbb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1096
Changes
pgerrcodeconstantsDownsides
Unfortunately I had to split the ping context with timeout from the database version check one, this means there's now two timeouts: