leaderboard rank cache improvements #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sesposito
approved these changes
Jul 7, 2023
| assert.EqualValues(t, 2, cache.Get("lid", order, 44, 45, 0, u4)) | ||
| assert.EqualValues(t, 3, cache.Get("lid", order, 33, 34, 0, u3)) | ||
| assert.EqualValues(t, 4, cache.Get("lid", order, 22, 23, 0, u2)) | ||
| assert.EqualValues(t, 5, cache.Get("lid", order, 11, 12, 0, u1)) |
There was a problem hiding this comment.
Should we also add a test for tied scores that are untied by the subscore?
There was a problem hiding this comment.
Good idea! Will do 👍
syhpoon
force-pushed
the
lb-rank-cache-opt
branch
4 times, most recently
from
9d03c60
to
e5e796c
Compare
syhpoon
force-pushed
the
lb-rank-cache-opt
branch
from
e5e796c
to
0402e77
Compare
zyro
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.