Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): fix and improve VS Code mention #741

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

n0toose
Copy link
Member

@n0toose n0toose commented Aug 17, 2024

  • "Visual Code" is a typo
  • instructions are not Visual Studio Code specific
  • Add URLs to the projects' respective pages (purely cosmetic)

- "Visual Code" is a typo
- instructions are not Visual Studio Code specific
- Add URLs to the projects' respective pages (purely cosmetic)
@n0toose
Copy link
Member Author

n0toose commented Aug 17, 2024

had to force-push real quick so as to make the README in the commit message lowercase, it's a detail but eh it's fine :)

@n0toose n0toose changed the title docs(README): fix and improve VS Code mention docs(readme): fix and improve VS Code mention Aug 17, 2024
Copy link

codecov bot commented Aug 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.24%. Comparing base (5c9a2fd) to head (e00fef0).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #741   +/-   ##
=======================================
  Coverage   67.24%   67.24%           
=======================================
  Files          20       20           
  Lines        2351     2351           
=======================================
  Hits         1581     1581           
  Misses        770      770           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jounathaen
Copy link
Member

Nice find, thanks!

@jounathaen jounathaen added this pull request to the merge queue Aug 23, 2024
Merged via the queue into hermit-os:main with commit 4d37153 Aug 23, 2024
10 checks passed
@jounathaen jounathaen deleted the readme-vscode-fix branch August 23, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants