find_kernel: fix ELF module boundaries #377
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cases where we want to page a range rather than a certain number of pages, use map_page to eliminate the need to calculate the page count.
containing_page calls already align the addresses down. As such, we do not need to align the addresses down ourselves.
Instead of checking if it is the first iteration of the loop in every iteration, handle the first iteration of the modules iterator outside the loop.
cagatay-y
force-pushed
the
module-boundaries
branch
from
f649c1f
to
edb3d39
Compare
cagatay-y
force-pushed
the
module-boundaries
branch
from
edb3d39
to
2c5840c
Compare
cagatay-y
force-pushed
the
module-boundaries
branch
2 times, most recently
from
92a7d3f
to
a6c7a1d
Compare
The end address for all the modules seemed to be confused with the end address for the first module.
cagatay-y
force-pushed
the
module-boundaries
branch
from
a6c7a1d
to
536f543
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not very sure about this one, but I think the function is supposed the return the slice between the start and end addresses in the first module. It looks like the end value for the first module and the maximum end value for all the modules (needed for mapping them) was confused. If my understanding is correct, the caller would still work because the functions it calls determine the length it reads from the returned slice by other means, so the slice being too large does not hurt.