Adding tycho functionality #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-seals
requested review from
waTeim,
Hoid,
hina-shah,
frostyfan109,
pj-linebaugh and
cnbennett3
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Hoid
approved these changes
May 20, 2024
|
Approving just for my changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can use the currently built image to test this if you'd like, the tag is "test_reintegrate_tycho" .
The reasons to merge tycho back to appstore are simplicity of development, release and dependency management. There is really no need for a separate library since no one uses tycho except appstore and many advancements to k8s have occurred since tycho's inception making it's focus on translating docker-compose dated. I have not changed anything to the code however but did leave out the api.py from tycho as it doesn't need an api outside of what appstore has.