Upgrade to Django 4.2, add actions, integrate tycho and cleanup. #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jan 2024 patches
ENH: Add RADX logo
Eduhelx-data715 settings changes.
fix: Re-add install clause of Makefile.
Update django 4.2. This merge is accompanied with appstore-chart PR: helxplatform/appstore-chart#107
feat: Adding whitelisting via usernames (onyens for UNC SAML)
Adding tycho functionality
joshua-seals
changed the title
joshua-seals
approved these changes
May 20, 2024
Hoid
reviewed
May 20, 2024
Comment on lines
+244
to
+245
| # UNC Relay: relay.unc.edu:25 | ||
| # Renci Relay: relay.renci.org |
There was a problem hiding this comment.
I would just remove these kinds of things if we don't need them anymore. If we need to go back and find them later, that's what version control is for
Hoid
reviewed
May 20, 2024
| @@ -18,9 +18,16 @@ | |||
|
|
|||
|
|
|||
| class AllowWhiteListedUserOnly(MiddlewareMixin): | |||
| def __init__(self, get_response=None): | |||
| if get_response is not None: | |||
There was a problem hiding this comment.
This can be rewritten as
self.get_response = get_response ? get_response : self._get_response
if you care about that kind of thing. No big deal though.
There was a problem hiding this comment.
Is Ternary too clever?
Hoid
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.