Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(example): update codesandbox links and dependencies version #746

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

worapolburaphan
Copy link

No description provided.

Copy link

vercel bot commented Jan 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dnd ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2024 10:52am

@worapolburaphan worapolburaphan changed the title doc(example): update codesandbox link and dependency version doc(example): update codesandbox links and dependencies version Jan 8, 2024
@100terres
Copy link
Collaborator

Hi @worapolburaphan 👋

Thank you for taking the time to open this pull request. It is really appreciated 😊

I would like to know why we need to update the sandbox links?

@worapolburaphan
Copy link
Author

worapolburaphan commented Jan 30, 2024

Hi @worapolburaphan 👋

Thank you for taking the time to open this pull request. It is really appreciated 😊

I would like to know why we need to update the sandbox links?

Hi, @100terres

I have 3 reasons to update it. (There might be no need to do so if the owner’s sandbox link has been updated for this.

  1. Migrate dependency of react-buetiful-dnd to hello-pangea/dnd

  2. For sandbox link of "vertical list with multiple drop targets" is broken build
    https://codesandbox.io/p/sandbox/ql08j35j3q?file=%2Findex.js
    image

  3. Update React to the latest version. Maybe someone can do more things with the latest version when there fork or do some experimental on sanbox

@100terres 100terres self-assigned this Mar 24, 2024
@100terres 100terres added the documentation Improvements or additions to documentation label Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants