Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): add support for react 18 #322

Merged
merged 24 commits into from
Aug 21, 2022
Merged

feat(deps): add support for react 18 #322

merged 24 commits into from
Aug 21, 2022

Conversation

100terres
Copy link
Collaborator

@100terres 100terres commented Apr 11, 2022

fix #293

@imekachi
Copy link

imekachi commented May 7, 2022

Hi @100terres, thank you for working on this and keeping this package alive.
I think there are lots of people waiting for this and some might want to help.
Could you provide a checklist of what needs to be done just in case someone wants to help with this?

@oravecz
Copy link

oravecz commented Jul 28, 2022

wtf would you fork to add React 18 dependency and not publish the package? Some problem with the code running under React 18?

@100terres
Copy link
Collaborator Author

@imekachi @oravecz we might be able to release a beta version this weekend. I'll keep you posted.

@100terres 100terres changed the title Support react v18 feat(deps): add support for react 18 Aug 21, 2022
@oravecz
Copy link

oravecz commented Aug 21, 2022

Re-read my comment. Apologize for the wording. Thanks for the release.

@100terres 100terres force-pushed the react-18 branch 2 times, most recently from c663c72 to 552b8f7 Compare August 21, 2022 18:31
This will allow @react-forked/dnd to be installed using react v18

fix #319
* test(dev-deps): remove enzyme libraries from package.json

* test(setup): remove enzyme related configuration

* test: move REACT_VERSION global declaration

* test(dev-deps): setup @testing-library/jest-dom

for more details see: https://github.com/testing-library/jest-dom#usage=

* test(jsdom env): fix issue with missing TransitionEvent

* test(enzyme): drop Placeholder without memo (needed for enzyme)

* test(enzyme): drop force upfate util

* test(enzyme): drop PassThroughProps util component

Not needed anymore, because with @testing-library/react there are no equivalent to the `setProp`. We
must use the `rerender` function and we can directly change the prop of child component in the tree
if needed.

* test(util): drop un-used user input util

* test(enzyme): migrate all tests using enzyme to @testing-library/react

* chore: bump size snapshot
@100terres
Copy link
Collaborator Author

@oravecz

Some problem with the code running under React 18?

Exacly! React 18 brought a couple of breaking changes and it was not an easy fix. Also some of our depedencies needed to be upgraded and in the case of enzyme we needed to completly drop it and use something else. There had been a lot of investigations and code changes.

@100terres 100terres marked this pull request as ready for review August 21, 2022 20:26
@100terres
Copy link
Collaborator Author

100terres commented Aug 21, 2022

@100terres 100terres requested a review from Xhale1 August 21, 2022 23:19
@100terres 100terres merged commit 227ed74 into main Aug 21, 2022
@100terres 100terres deleted the react-18 branch August 21, 2022 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support react v18 and Strict Mode
3 participants